Skip to content

Commit 61d62f2

Browse files
committed
Adds notes/references to the requests lib issue
1 parent 2a2ca0f commit 61d62f2

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

SoftLayer/tests/functional_tests.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ def test_no_hostname(self):
3838
SoftLayer.transports.make_xml_rpc_api_call(
3939
'http://notvalidsoftlayer.com', 'getObject')
4040
except Exception as ex:
41+
# NOTE(sudorandom): This used to be an instance of
42+
# SoftLayer.SoftLayerAPIError
43+
# Related issue: https://github.com/kennethreitz/requests/pull/2193
4144
self.assertIn('not known', str(ex))
4245
else:
4346
self.fail('No Exception Raised')

SoftLayer/tests/transport_tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ def test_proxy_without_protocol(self):
6363
# NOTE(sudorandom): This used to be an instance of requests.HTTPError,
6464
# but something changes in requests to make that no
6565
# longer the case.
66+
# Related issue:
67+
# https://github.com/kennethreitz/requests/pull/2193
6668
self.assertRaises(
6769
Exception, # NOQA
6870
transports.make_xml_rpc_api_call,

0 commit comments

Comments
 (0)