change pmengal#31 - Update export ToString code.

reinaldocoelho · reinaldocoelho · commit 6b902862c1cf · 2017-08-29T11:00:29.000-03:00
diff --git a/.vs/ActiveUp.Net-vs2017/v15/sqlite3/storage.ide b/.vs/ActiveUp.Net-vs2017/v15/sqlite3/storage.ide
diff --git a/ActiveUp.Net-vs2017.sln b/ActiveUp.Net-vs2017.sln
@@ -1,7 +1,7 @@
 ﻿
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 14
-VisualStudioVersion = 14.0.25123.0
+# Visual Studio 15
+VisualStudioVersion = 15.0.26730.10
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Class Library", "Class Library", "{629D406B-F46A-4A9D-A31F-C5956E0AB157}"
 EndProject
@@ -633,4 +633,7 @@ Global
 		{5AD3438E-9024-4908-BA15-92726159C4FB} = {33BAFFED-FB5D-48EF-85D9-CDE2EB2CFA64}
 		{25DA9502-B959-4E81-9368-471AE231BCC0} = {629D406B-F46A-4A9D-A31F-C5956E0AB157}
 	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {BBCFB72D-84B7-4F14-BA2E-A464210881F7}
+	EndGlobalSection
 EndGlobal
diff --git a/Class Library/ActiveUp.Net.Common/TraceInfo.cs b/Class Library/ActiveUp.Net.Common/TraceInfo.cs
@@ -95,22 +95,22 @@ private void Initialize(string from, DateTime date, string by, string via, strin
         public override string ToString()
         {
             string source = string.Empty;
-            if (!From.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(From))
                 source += " from " + From + "\r\n ";
-            if (!By.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(By))
                 source += " by " + By + "\r\n ";
-            if (!With.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(With))
                 source += " with " + With + "\r\n ";
-            if (!For.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(For))
                 source += " for " + For + "\r\n ";
-            if (!Via.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(Via))
                 source += " via " + Via + "\r\n ";
-            if (!Id.Equals(string.Empty))
+            if (!string.IsNullOrEmpty(Id))
                 source += " id " + Id + "\r\n ";
 
             if (string.IsNullOrEmpty(source))
                 return "";
-            return source.Remove(0,source.Length - 3) + ";" + Date.ToString("r");
+            return source.Remove(0, source.Length - 3) + ";" + Date.ToString("r");
         }
     }
 }
diff --git a/Class Library/ActiveUp.Net.Tests/ActiveUp.Net.Tests.csproj b/Class Library/ActiveUp.Net.Tests/ActiveUp.Net.Tests.csproj
@@ -82,6 +82,7 @@
     <Compile Include="Common\MimePartTests.cs" />
     <Compile Include="Common\RFC2047\Rfc2047DecoderTests.cs" />
     <Compile Include="Common\RFC2047\Rfc2047DecoderTests.Splitter.cs" />
+    <Compile Include="Common\TraceInfoTests.cs" />
     <Compile Include="FluentTests.cs" />
     <Compile Include="Groupware\ParserTests.cs" />
     <Compile Include="ImapTests.cs" />
diff --git a/Class Library/ActiveUp.Net.Tests/Common/ParserTests.cs b/Class Library/ActiveUp.Net.Tests/Common/ParserTests.cs
@@ -3,7 +3,6 @@
 using ActiveUp.Net.Mail;
 using NUnit.Framework;
 using System.Reflection;
-using System.Text;
 
 namespace ActiveUp.Net.Tests.Common
 {
diff --git a/Class Library/ActiveUp.Net.Tests/Common/TraceInfoTests.cs b/Class Library/ActiveUp.Net.Tests/Common/TraceInfoTests.cs
@@ -0,0 +1,17 @@
+using ActiveUp.Net.Mail;
+using NUnit.Framework;
+using System;
+
+namespace ActiveUp.Net.Tests.Common
+{
+    [TestFixture]
+    public class TraceInfoTests
+    {
+        [Test]
+        public void should_process_null_values()
+        {
+            var test = new TraceInfo(null, DateTime.MinValue, null, null, null, null, null);
+            Assert.AreEqual("", test.ToString());
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`using ActiveUp.Net.Mail;`
`4`	`4`	`using NUnit.Framework;`
`5`	`5`	`using System.Reflection;`
`6`		`-using System.Text;`
`7`	`6`
`8`	`7`	`namespace ActiveUp.Net.Tests.Common`
`9`	`8`	`{`