Skip to content

Correcting the postinstall script command line#7012

Closed
SeriousM wants to merge 1 commit intoangular:masterfrom
SeriousM:patch-1
Closed

Correcting the postinstall script command line#7012
SeriousM wants to merge 1 commit intoangular:masterfrom
SeriousM:patch-1

Conversation

@SeriousM
Copy link
Copy Markdown

For some reason typings is reading "typings install ... github:DefinitelyTyped/...#hash; typings install ... github:DefinitelyTyped/..#hash" wrong and tries to retrieve " https://raw.githubusercontent.com/DefinitelyTyped/.../hash;/.../file.d.ts" from github which does not work.
Please notice the place of the ';' in the commandline as well on the url.
To fix this just chain the two typings installations with & which also ensures that the first command have to work.

For some reason typings is reading "typings install ... github:DefinitelyTyped/...#hash; typings install ... github:DefinitelyTyped/..#hash" wrong and tries to retrieve " https://raw.githubusercontent.com/DefinitelyTyped/.../hash;/.../file.d.ts" from github which does not work.
Please notice the place of the ';' in the commandline as well on the url.
To fix this just chain the two typings installations with & which also ensures that the first command have to work.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@SeriousM
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@alexeagle
Copy link
Copy Markdown
Contributor

Hey, this does solve the problem for Windows users - but some non-Windows users also had errors running the postinstall. So we need one of #7011 or #7003 instead.

@alexeagle alexeagle closed this Feb 11, 2016
@SeriousM SeriousM deleted the patch-1 branch February 11, 2016 15:45
@SeriousM
Copy link
Copy Markdown
Author

Alright, thank you for clarification. 👍

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants