fix(router): add extra validation for when route was passed as Array.#9942
Merged
vicb merged 1 commit intoangular:masterfrom Jul 14, 2016
Merged
Conversation
Contributor
|
please update and squash your commits |
65acbcf to
8b900f8
Compare
8b900f8 to
da43c6c
Compare
Contributor
Author
|
@vicb |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When route are given as Array, Angular throws error with
Invalid route configuration: routes must have path specifiedwhich does not really express what's wrong.What is the new behavior?
Throw error with new message
Invalid route configuration: Array cannot be specified.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I'm certain that there are some people who think route can be given as array and it should be eventually flattened.
I hope this will them to figure out the problem they are having.
(Current error message confused me a little bit, and took sometime to resolve it.)