feat(@ngtools/webpack): adjust changed file extensions based on usage

clydin · clydin · commit ac4da98911ca · 2018-01-27T14:17:54.000-05:00
diff --git a/packages/@ngtools/webpack/src/angular_compiler_plugin.ts b/packages/@ngtools/webpack/src/angular_compiler_plugin.ts
@@ -103,6 +103,7 @@ export class AngularCompilerPlugin implements Tapable {
   private _platform: PLATFORM;
   private _JitMode = false;
   private _emitSkipped = true;
+  private _changedFileExtensions = new Set(['ts', 'html', 'css']);
 
   // Webpack plugin.
   private _firstRun = true;
@@ -292,9 +293,22 @@ export class AngularCompilerPlugin implements Tapable {
       .filter(k => this._compilerHost.fileExists(k));
   }
 
+  updateChangedFileExtensions(extension: string) {
+    if (extension) {
+      this._changedFileExtensions.add(extension);
+    }
+  }
+
   private _getChangedCompilationFiles() {
     return this._compilerHost.getChangedFilePaths()
-      .filter(k => /\.(?:ts|html|css|scss|sass|less|styl)$/.test(k));
+      .filter(k => {
+        for (const ext of this._changedFileExtensions) {
+          if (k.endsWith(ext)) {
+            return true;
+          }
+        }
+        return false;
+      });
   }
 
   private _createOrUpdateProgram() {
diff --git a/packages/@ngtools/webpack/src/loader.ts b/packages/@ngtools/webpack/src/loader.ts
@@ -589,7 +589,10 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
           if (sourceFileName.endsWith('.ts')) {
             result.errorDependencies.forEach(dep => this.addDependency(dep));
             const dependencies = plugin.getDependencies(sourceFileName);
-            dependencies.forEach(dep => this.addDependency(dep));
+            dependencies.forEach(dep => {
+              plugin.updateChangedFileExtensions(path.extname(dep));
+              this.addDependency(dep);
+            });
           }
 
           // NgFactory files depend on the component template, but we can't know what that file
@@ -601,7 +604,10 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
             const originalFile = sourceFileName.replace(ngFactoryRe, '.ts');
             this.addDependency(originalFile);
             const origDependencies = plugin.getDependencies(originalFile);
-            origDependencies.forEach(dep => this.addDependency(dep));
+            origDependencies.forEach(dep => {
+              plugin.updateChangedFileExtensions(path.extname(dep));
+              this.addDependency(dep);
+            });
           }
 
           // NgStyle files depend on the style file they represent.
@@ -611,7 +617,10 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
           if (ngStyleRe.test(sourceFileName)) {
             const styleFile = sourceFileName.replace(ngStyleRe, '');
             const styleDependencies = plugin.getResourceDependencies(styleFile);
-            styleDependencies.forEach(dep => this.addDependency(dep));
+            styleDependencies.forEach(dep => {
+              plugin.updateChangedFileExtensions(path.extname(dep));
+              this.addDependency(dep);
+            });
           }
 
           timeEnd(timeLabel);
