Merge pull request #259 from Gwe-n/fix-min-size

SanderElias · web-flow · commit bc139ee8fe0f · 2024-01-25T06:43:32.000+01:00
fix: keep minSize, even when size is undefined
diff --git a/projects/angular-split/src/lib/component/split.component.ts b/projects/angular-split/src/lib/component/split.component.ts
@@ -472,7 +472,7 @@ export class SplitComponent implements AfterViewInit, OnDestroy {
             if (wildcardSizeAreas.length === 0 && this.displayedAreas.length > 0) {
               this.displayedAreas.forEach((area, i) => {
                 area.size = i === 0 ? '*' : area.component.size
-                area.minSize = i === 0 ? null : getAreaMinSize(area)
+                area.minSize = i === 0 ? area.component.minSize : getAreaMinSize(area)
                 area.maxSize = i === 0 ? null : getAreaMaxSize(area)
               })
             } else if (wildcardSizeAreas.length > 1) {
diff --git a/projects/angular-split/src/lib/utils.ts b/projects/angular-split/src/lib/utils.ts
@@ -161,10 +161,6 @@ export function getAreaMinSize(a: IArea): number | null {
     return null
   }
 
-  if (a.component.minSize > a.size) {
-    return a.size
-  }
-
   return a.component.minSize
 }
 

Original file line number	Diff line number	Diff line change
`@@ -161,10 +161,6 @@ export function getAreaMinSize(a: IArea): number \| null {`
`161`	`161`	`return null`
`162`	`162`	`}`
`163`	`163`
`164`		`- if (a.component.minSize > a.size) {`
`165`		`- return a.size`
`166`		`- }`
`167`		`-`
`168`	`164`	`return a.component.minSize`
`169`	`165`	`}`
`170`	`166`