[ZEPPELIN-6243] Remove unused code in SemanticVersion class

eunhwa99 · web-flow · commit e4f4cc88ed7f · 2025-07-21T10:05:59.000+02:00
### What is this PR for? This PR performs internal cleanup in the org.apache.zeppelin.test.SemanticVersion class by removing unused methods: These methods are not referenced anywhere in the Zeppelin codebase and serve no current functional purpose. ### What type of PR is it? Refactoring ### Todos * [x] - Remove unused methods in SemanticVersion ### What is the Jira issue? * [JIRA](https://issues.apache.org/jira/browse/ZEPPELIN-6243) ### How should this be tested? * No functional changes. No additional testing required. * CI should pass as usual. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Closes #4978 from eunhwa99/ZEPPELIN-6243. Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
diff --git a/zeppelin-test/src/main/java/org/apache/zeppelin/test/SemanticVersion.java b/zeppelin-test/src/main/java/org/apache/zeppelin/test/SemanticVersion.java
@@ -23,22 +23,20 @@
 /**
  * Provide reading comparing capability of semantic version which is used widely in Apache projects
  */
-public class SemanticVersion {
+public class SemanticVersion implements Comparable<SemanticVersion> {
+
   private static final Logger LOGGER = LoggerFactory.getLogger(SemanticVersion.class);
 
   public static SemanticVersion of(String versionString) {
     return new SemanticVersion(versionString);
   }
 
   private final String versionString;
-  private int version;
-  private int majorVersion;
-  private int minorVersion;
-  private int patchVersion;
+  private final int version;
 
   private SemanticVersion(String versionString) {
     this.versionString = versionString;
-
+    int version;
     try {
       int pos = versionString.indexOf('-');
 
@@ -48,28 +46,19 @@ private SemanticVersion(String versionString) {
       }
 
       String[] versions = numberPart.split("\\.");
-      this.majorVersion = Integer.parseInt(versions[0]);
-      this.minorVersion = Integer.parseInt(versions[1]);
-      this.patchVersion = Integer.parseInt(versions[2]);
+      int majorVersion = Integer.parseInt(versions[0]);
+      int minorVersion = Integer.parseInt(versions[1]);
+      int patchVersion = Integer.parseInt(versions[2]);
       // version is always 5 digits. (e.g. 2.0.0 -> 20000, 1.6.2 -> 10602)
-      version = Integer.parseInt(String.format("%d%02d%02d", majorVersion, minorVersion, patchVersion));
+      version = Integer.parseInt(
+          String.format("%d%02d%02d", majorVersion, minorVersion, patchVersion));
     } catch (Exception e) {
-      LOGGER.error("Can not recognize Spark version {}. Assume it's a future release", versionString, e);
+      LOGGER.error("Can not recognize Spark version {}. Assume it's a future release",
+          versionString, e);
       // assume it is future release
       version = 99999;
     }
-  }
-
-  public int getMajorVersion() {
-    return majorVersion;
-  }
-
-  public int getMinorVersion() {
-    return minorVersion;
-  }
-
-  public int getPatchVersion() {
-    return patchVersion;
+    this.version = version;
   }
 
   @Override
@@ -85,22 +74,15 @@ public int hashCode() {
   @Override
   public boolean equals(Object versionToCompare) {
     return versionToCompare instanceof SemanticVersion
-            && version == ((SemanticVersion) versionToCompare).version;
+        && this.compareTo((SemanticVersion) versionToCompare) == 0;
   }
 
-  public boolean newerThan(SemanticVersion versionToCompare) {
-    return version > versionToCompare.version;
+  @Override
+  public int compareTo(SemanticVersion other) {
+    return Integer.compare(this.version, other.version);
   }
 
   public boolean equalsOrNewerThan(SemanticVersion versionToCompare) {
-    return version >= versionToCompare.version;
-  }
-
-  public boolean olderThan(SemanticVersion versionToCompare) {
-    return version < versionToCompare.version;
-  }
-
-  public boolean equalsOrOlderThan(SemanticVersion versionToCompare) {
-    return version <= versionToCompare.version;
+    return this.compareTo(versionToCompare) >= 0;
   }
 }
