-
Notifications
You must be signed in to change notification settings - Fork 17
Address accessing of non-existing field _maybe_parsed_body within httpx.Response object #166
Copy link
Copy link
Closed
Labels
bugSomething isn't working.Something isn't working.t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Description
It seems that the following code:
response: httpx.Response = await self.http_client.call(
url=self._url(f'records/{key}'),
method='GET',
params=self._params(),
)returns a response of type httpx.Response. Later the field _maybe_parsed_body is accessed:
return {
'value': response._maybe_parsed_body,
'...': '...',
}There are 2 occurrences of this:
- https://github.com/apify/apify-client-python/blob/v1.6.0/src/apify_client/clients/resource_clients/key_value_store.py#L120
- https://github.com/apify/apify-client-python/blob/v1.6.0/src/apify_client/clients/resource_clients/key_value_store.py#L323
Check if http_client.call really returns a httpx.Response object and in such case fix the accessing of non-existing field _maybe_parsed_body.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't working.Something isn't working.t-toolingIssues with this label are in the ownership of the tooling team.Issues with this label are in the ownership of the tooling team.
Type
Fields
Give feedbackNo fields configured for issues without a type.