Remove unneeded code

aplotnikov · aplotnikov · commit 0f79adb82760 · 2018-12-30T00:35:11.000+01:00
diff --git a/src/main/java/io/github/aplotnikov/java_8_misuses/stream/CreationOptions.java b/src/main/java/io/github/aplotnikov/java_8_misuses/stream/CreationOptions.java
@@ -18,51 +18,51 @@
 class CreationOptions {
 
     @Ugly
-    public Stream<Type> getStreamOfApplicationTypesFromArrayAsList() {
+    Stream<Type> getStreamOfApplicationTypesFromArrayAsList() {
         return Arrays.asList(MAIN, EXTENSION).stream();
     }
 
     @Ugly
-    public Stream<Type> getStreamOfApplicationTypesForFactoryMethod() {
+    Stream<Type> getStreamOfApplicationTypesForFactoryMethod() {
         return List.of(MAIN, EXTENSION).stream();
     }
 
     @Good
-    public Stream<Type> getStreamFromElements() {
+    Stream<Type> getStreamFromElements() {
         return Stream.of(MAIN, EXTENSION);
     }
 
     @Ugly
-    public Stream<Loan> generateStreamByMappingCopies(int n) {
+    Stream<Loan> generateStreamByMappingCopies(int n) {
         return Collections.nCopies(n, "ignored")
                           .stream()
                           .map(ignored -> new Loan());
     }
 
     @Ugly
-    public Stream<Loan> generateStreamFromRange(int n) {
+    Stream<Loan> generateStreamFromRange(int n) {
         return IntStream.range(0, n).mapToObj(ignored -> new Loan());
     }
 
     @Good
-    public Stream<Loan> generateStreamFromSupplierWithLimit(int n) {
+    Stream<Loan> generateStreamFromSupplierWithLimit(int n) {
         return Stream.generate(Loan::new).limit(n);
     }
 
     @Ugly
-    public Stream<Loan> generateStreamFromArrayWithRange(Loan[] loans, int max) {
+    Stream<Loan> generateStreamFromArrayWithRange(Loan[] loans, int max) {
         int to = Integer.min(loans.length, max);
         return IntStream.range(0, to).mapToObj(i -> loans[i]);
     }
 
     @Bad
-    public Stream<Loan> generateStreamFromArrayStreamWithRange(Loan[] loans, int max) {
+    Stream<Loan> generateStreamFromArrayStreamWithRange(Loan[] loans, int max) {
         int to = Integer.min(loans.length, max);
         return Arrays.stream(loans, 0, to);
     }
 
     @Good
-    public Stream<Loan> generateStreamFromArrayWithLimit(Loan[] loans, int max) {
+    Stream<Loan> generateStreamFromArrayWithLimit(Loan[] loans, int max) {
         return Stream.of(loans).limit(max);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,51 +18,51 @@`
`18`	`18`	`class CreationOptions {`
`19`	`19`
`20`	`20`	`@Ugly`
`21`		`- public Stream<Type> getStreamOfApplicationTypesFromArrayAsList() {`
	`21`	`+ Stream<Type> getStreamOfApplicationTypesFromArrayAsList() {`
`22`	`22`	`return Arrays.asList(MAIN, EXTENSION).stream();`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`@Ugly`
`26`		`- public Stream<Type> getStreamOfApplicationTypesForFactoryMethod() {`
	`26`	`+ Stream<Type> getStreamOfApplicationTypesForFactoryMethod() {`
`27`	`27`	`return List.of(MAIN, EXTENSION).stream();`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`@Good`
`31`		`- public Stream<Type> getStreamFromElements() {`
	`31`	`+ Stream<Type> getStreamFromElements() {`
`32`	`32`	`return Stream.of(MAIN, EXTENSION);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`@Ugly`
`36`		`- public Stream<Loan> generateStreamByMappingCopies(int n) {`
	`36`	`+ Stream<Loan> generateStreamByMappingCopies(int n) {`
`37`	`37`	`return Collections.nCopies(n, "ignored")`
`38`	`38`	`.stream()`
`39`	`39`	`.map(ignored -> new Loan());`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`@Ugly`
`43`		`- public Stream<Loan> generateStreamFromRange(int n) {`
	`43`	`+ Stream<Loan> generateStreamFromRange(int n) {`
`44`	`44`	`return IntStream.range(0, n).mapToObj(ignored -> new Loan());`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`@Good`
`48`		`- public Stream<Loan> generateStreamFromSupplierWithLimit(int n) {`
	`48`	`+ Stream<Loan> generateStreamFromSupplierWithLimit(int n) {`
`49`	`49`	`return Stream.generate(Loan::new).limit(n);`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`@Ugly`
`53`		`- public Stream<Loan> generateStreamFromArrayWithRange(Loan[] loans, int max) {`
	`53`	`+ Stream<Loan> generateStreamFromArrayWithRange(Loan[] loans, int max) {`
`54`	`54`	`int to = Integer.min(loans.length, max);`
`55`	`55`	`return IntStream.range(0, to).mapToObj(i -> loans[i]);`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`@Bad`
`59`		`- public Stream<Loan> generateStreamFromArrayStreamWithRange(Loan[] loans, int max) {`
	`59`	`+ Stream<Loan> generateStreamFromArrayStreamWithRange(Loan[] loans, int max) {`
`60`	`60`	`int to = Integer.min(loans.length, max);`
`61`	`61`	`return Arrays.stream(loans, 0, to);`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`@Good`
`65`		`- public Stream<Loan> generateStreamFromArrayWithLimit(Loan[] loans, int max) {`
	`65`	`+ Stream<Loan> generateStreamFromArrayWithLimit(Loan[] loans, int max) {`
`66`	`66`	`return Stream.of(loans).limit(max);`
`67`	`67`	`}`
`68`	`68`	`}`