Merge pull request #10691 from appwrite/chore-skip-auth-to-delete-vcs-lock

Meldiron · web-flow · commit 046d1190cf44 · 2025-10-23T18:00:58.000+02:00
Skip auth check to delete vcs lock document
diff --git a/app/controllers/api/vcs.php b/app/controllers/api/vcs.php
@@ -166,7 +166,7 @@
 
                             $latestCommentId = \strval($github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment()));
                         } finally {
-                            $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);
+                            Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));
                         }
                     }
                 } else {
@@ -237,7 +237,7 @@
 
                             $latestCommentId = \strval($github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment()));
                         } finally {
-                            $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);
+                            Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));
                         }
                     }
                 }
@@ -458,7 +458,7 @@
                             $github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment());
                         }
                     } finally {
-                        $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);
+                        Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));
                     }
                 }
             }
@@ -1374,7 +1374,7 @@ function (GitHub $github, Request $request, Response $response, Database $dbForP
                             Authorization::skip(fn () => $dbForPlatform->deleteDocument('repositories', $repository->getId()));
                         }
 
-                        $dbForPlatform->deleteDocument('installations', $installation->getId());
+                        Authorization::skip(fn () => $dbForPlatform->deleteDocument('installations', $installation->getId()));
                     }
                 }
             } elseif ($event == $github::EVENT_PULL_REQUEST) {

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@`
`166`	`166`
`167`	`167`	`$latestCommentId = \strval($github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment()));`
`168`	`168`	`} finally {`
`169`		`- $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);`
	`169`	`+ Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));`
`170`	`170`	`}`
`171`	`171`	`}`
`172`	`172`	`} else {`
`@@ -237,7 +237,7 @@`
`237`	`237`
`238`	`238`	`$latestCommentId = \strval($github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment()));`
`239`	`239`	`} finally {`
`240`		`- $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);`
	`240`	`+ Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));`
`241`	`241`	`}`
`242`	`242`	`}`
`243`	`243`	`}`
`@@ -458,7 +458,7 @@`
`458`	`458`	`$github->updateComment($owner, $repositoryName, $latestCommentId, $comment->generateComment());`
`459`	`459`	`}`
`460`	`460`	`} finally {`
`461`		`- $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId);`
	`461`	`+ Authorization::skip(fn () => $dbForPlatform->deleteDocument('vcsCommentLocks', $latestCommentId));`
`462`	`462`	`}`
`463`	`463`	`}`
`464`	`464`	`}`
`@@ -1374,7 +1374,7 @@ function (GitHub $github, Request $request, Response $response, Database $dbForP`
`1374`	`1374`	`Authorization::skip(fn () => $dbForPlatform->deleteDocument('repositories', $repository->getId()));`
`1375`	`1375`	`}`
`1376`	`1376`
`1377`		`- $dbForPlatform->deleteDocument('installations', $installation->getId());`
	`1377`	`+ Authorization::skip(fn () => $dbForPlatform->deleteDocument('installations', $installation->getId()));`
`1378`	`1378`	`}`
`1379`	`1379`	`}`
`1380`	`1380`	`} elseif ($event == $github::EVENT_PULL_REQUEST) {`