Update src/Appwrite/Platform/Modules/Health/Http/Health/Certificate/Get.php

lohanidamodar · coderabbitai[bot] · web-flow · commit 4ef906b83612 · 2026-01-01T13:15:28.000+05:45
Co-authored-by: coderabbitai[bot] &lt;136622811+coderabbitai[bot]@users.noreply.github.com&gt;
diff --git a/src/Appwrite/Platform/Modules/Health/Http/Health/Certificate/Get.php b/src/Appwrite/Platform/Modules/Health/Http/Health/Certificate/Get.php
@@ -72,6 +72,12 @@ public function action(string $domain, Response $response): void
         $streamContextParams = stream_context_get_params($sslSocket);
         $peerCertificate = $streamContextParams['options']['ssl']['peer_certificate'];
         $certificatePayload = openssl_x509_parse($peerCertificate);
+        
+        fclose($sslSocket); // Close the socket to prevent resource leak
+        
+        if ($certificatePayload === false) {
+            throw new Exception(Exception::HEALTH_INVALID_HOST);
+        }
 
         $sslExpiration = $certificatePayload['validTo_time_t'];
         $status = $sslExpiration < time() ? 'fail' : 'pass';
@@ -81,12 +87,11 @@ public function action(string $domain, Response $response): void
         }
 
         $response->dynamic(new Document([
-            'name' => $certificatePayload['name'],
-            'subjectSN' => $certificatePayload['subject']['CN'],
-            'issuerOrganisation' => $certificatePayload['issuer']['O'],
+            'name' => $certificatePayload['name'] ?? '',
+            'subjectCN' => $certificatePayload['subject']['CN'] ?? '',
+            'issuerOrganisation' => $certificatePayload['issuer']['O'] ?? '',
             'validFrom' => $certificatePayload['validFrom_time_t'],
             'validTo' => $certificatePayload['validTo_time_t'],
-            'signatureTypeSN' => $certificatePayload['signatureTypeSN'],
+            'signatureTypeSN' => $certificatePayload['signatureTypeSN'] ?? '',
         ]), Response::MODEL_HEALTH_CERTIFICATE);
-    }
 }
