fix(serve): use configured host for v1 serve

imhoffd · imhoffd · commit 211906a86fdf · 2018-08-09T10:09:40.000-05:00
Fixes ionic-team#3496
diff --git a/packages/@ionic/v1-toolkit/src/lib/dev-server.ts b/packages/@ionic/v1-toolkit/src/lib/dev-server.ts
@@ -85,10 +85,10 @@ function getDevServerScript() {
 `;
 }
 
-export async function createLiveReloadServer({ port, wwwDir }: { port: number; wwwDir: string; }): Promise<LiveReloadFunction> {
+export async function createLiveReloadServer({ host, port, wwwDir }: { host: string, port: number; wwwDir: string; }): Promise<LiveReloadFunction> {
   const tinylr = await import('tiny-lr');
   const lrserver = tinylr();
-  lrserver.listen(port);
+  lrserver.listen(port, host);
 
   return changedFiles => {
     lrserver.changed({
@@ -128,10 +128,10 @@ function getLiveReloadScript(port: number) {
 `;
 }
 
-export async function createDevLoggerServer(port: number): Promise<ζws.Server> {
+export async function createDevLoggerServer(host: string, port: number): Promise<ζws.Server> {
   const WebSocket = await import('ws');
 
-  const wss = new WebSocket.Server({ port });
+  const wss = new WebSocket.Server({ host, port });
 
   wss.on('connection', ws => {
     ws.on('message', data => {
diff --git a/packages/@ionic/v1-toolkit/src/lib/serve.ts b/packages/@ionic/v1-toolkit/src/lib/serve.ts
@@ -63,7 +63,7 @@ export async function runServer(options: ServeOptions): Promise<ServeOptions> {
   let reloadfn: LiveReloadFunction | undefined;
 
   if (options.livereload) {
-    reloadfn = await createLiveReloadServer({ port: options.livereloadPort, wwwDir: options.wwwDir });
+    reloadfn = await createLiveReloadServer({ host: options.host, port: options.livereloadPort, wwwDir: options.wwwDir });
   }
 
   await createHttpServer(options);
@@ -149,7 +149,7 @@ async function createHttpServer(options: ServeOptions): Promise<ζexpress.Applic
 
   app.get(`/${DEV_SERVER_PREFIX}/dev-server.js`, await createDevServerHandler(options));
 
-  const wss = await createDevLoggerServer(options.devPort);
+  const wss = await createDevLoggerServer(options.host, options.devPort);
 
   return new Promise<ζexpress.Application>((resolve, reject) => {
     const httpserv = app.listen(options.port, options.host);
diff --git a/types/tiny-lr.d.ts b/types/tiny-lr.d.ts
@@ -4,7 +4,7 @@ declare module "tiny-lr" {
   namespace TinyLR {}
 
   interface TinyLRServer {
-    listen(port: number, cb?: () => {}): void;
+    listen(port: number, host: string, cb?: () => {}): void;
     close(): void;
     changed(p: any): void;
   }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ declare module "tiny-lr" {`
`4`	`4`	`namespace TinyLR {}`
`5`	`5`
`6`	`6`	`interface TinyLRServer {`
`7`		`- listen(port: number, cb?: () => {}): void;`
	`7`	`+ listen(port: number, host: string, cb?: () => {}): void;`
`8`	`8`	`close(): void;`
`9`	`9`	`changed(p: any): void;`
`10`	`10`	`}`