Skip to content

Commit f6eb1f0

Browse files
imhoffdimhoffd
committed
refactor: more types cleanup
1 parent 8b0350e commit f6eb1f0

13 files changed

Lines changed: 4 additions & 64 deletions

File tree

‎packages/@ionic/cli-framework/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
"write-file-atomic": "^2.3.0"
3939
},
4040
"devDependencies": {
41+
"@types/cross-spawn": "^6.0.0",
4142
"@types/debug": "0.0.30",
4243
"@types/inquirer": "0.0.42",
4344
"@types/klaw": "^2.1.1",

‎packages/@ionic/cli-framework/src/utils/shell.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ export class ShellCommand {
142142
}
143143
}
144144

145-
export function spawn(command: string, args?: ReadonlyArray<string>, options?: SpawnOptions): ChildProcess {
146-
return crossSpawn.spawn(command, args, options);
145+
export function spawn(command: string, args: ReadonlyArray<string> = [], options?: SpawnOptions): ChildProcess {
146+
return crossSpawn(command, [...args], options);
147147
}
148148

149149
export function fork(modulePath: string, args: ReadonlyArray<string> = [], options: ForkOptions & Pick<SpawnOptions, 'stdio'> = {}): ChildProcess {

‎packages/@ionic/cli-framework/tsconfig.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"outDir": "./"
55
},
66
"include": [
7-
"../../../types/cross-spawn.d.ts",
87
"../../../types/stream-combiner2.d.ts",
98
"../../../types/slice-ansi.d.ts",
109
"src/**/*.ts"

‎packages/@ionic/cli-utils/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
"@types/lodash": "^4.14.104",
6565
"@types/node": "^6.0.101",
6666
"@types/opn": "^5.1.0",
67+
"@types/os-name": "^2.0.0",
6768
"@types/semver": "^5.4.0",
6869
"@types/split2": "^2.1.6",
6970
"@types/tar": "^4.0.0",

‎packages/@ionic/cli-utils/tsconfig.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"include": [
77
"../../../types/elementtree.d.ts",
88
"../../../types/leek.d.ts",
9-
"../../../types/os-name.d.ts",
109
"../../../types/slice-ansi.d.ts",
1110
"../../../types/ssh-config.d.ts",
1211
"../../../types/stream-combiner2.d.ts",

‎packages/cli-scripts/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"@ionic/cli-framework": "1.0.0-rc.9",
2020
"@ionic/cli-utils": "2.0.0-rc.9",
2121
"ansi-styles": "^3.2.0",
22-
"ascii-tree": "^0.3.0",
2322
"chalk": "^2.3.0",
2423
"escape-string-regexp": "^1.0.5",
2524
"ionic": "4.0.0-rc.9",

‎packages/cli-scripts/tsconfig.json‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
"outDir": "./dist"
55
},
66
"include": [
7-
"../../types/ascii-tree.d.ts",
8-
"../../types/cross-spawn.d.ts",
97
"../../types/slice-ansi.d.ts",
108
"../../types/superagent.d.ts",
119
"src/**/*.ts"

‎packages/ionic/tsconfig.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
"outDir": "./dist"
55
},
66
"include": [
7-
"../../types/cross-spawn.d.ts",
87
"../../types/elementtree.d.ts",
98
"../../types/slice-ansi.d.ts",
109
"../../types/ssh-config.d.ts",

‎types/ascii-tree.d.ts‎

Lines changed: 0 additions & 6 deletions
This file was deleted.

‎types/boxen.d.ts‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)