Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Incorrect highlighting of raw bytes with non-decimal chars in strings #200

@ValarDragon

Description

@ValarDragon

Prerequisites

Description

In strings, normally '\xXX' makes the char at that position chr(int(XX,16)), it converts the hex value XX into that raw byte. However if one of the chars in X is non-decimal (so a-f) it doesn't get recognized.

Steps to Reproduce

Create the string "\x44\xff\x32RandomString\xa4\x4a\x44" in atom, and observe that the bytes with non decimal chars don't get highlighted.

Expected behavior:

All escaped hex bytes inside of strings to be highlighted.

Actual behavior: [What actually happens]

image

Reproduces how often: 100% of the time for me

Versions

I am on Linux Mint 17.3

atom 1.6.2
apm 1.6.0
npm 2.13.3
node 0.10.40
python 2.7.6
git 1.9.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions