Fix for issue ThatRendle#189

ThatRendle · ThatRendle · commit 5321b74afcad · 2012-05-20T00:29:21.000+01:00
diff --git a/Simple.Data.Ado/EagerLoadingEnumerable.cs b/Simple.Data.Ado/EagerLoadingEnumerable.cs
@@ -107,6 +107,7 @@ private class WithContainer
 
             public void AddToCollection(IDictionary<string,object> row)
             {
+                if (row.All(kvp => ReferenceEquals(null, kvp.Value))) return;
                 if (Collection == null) Collection = new HashSet<IDictionary<string, object>>(new DictionaryEqualityComparer());
                 Collection.Add(row);
             }
diff --git a/Simple.Data.SqlTest/QueryTest.cs b/Simple.Data.SqlTest/QueryTest.cs
@@ -392,6 +392,17 @@ public void WithClauseShouldCastToStaticTypeWithCollection()
             Assert.AreEqual(1, actual.Orders.Single().OrderId);
             Assert.AreEqual(new DateTime(2010,10,10), actual.Orders.Single().OrderDate);
         }
+        
+        [Test]
+        public void WithClauseShouldCastToStaticTypeWithEmptyCollection()
+        {
+            var db = DatabaseHelper.Open();
+            var newCustomer = db.Customers.Insert(Name: "No Orders");
+            Customer actual = db.Customers.FindAllByCustomerId(newCustomer.CustomerId).WithOrders().FirstOrDefault();
+            Assert.IsNotNull(actual);
+            Assert.IsNotNull(actual.Orders);
+            Assert.AreEqual(0, actual.Orders.Count);
+        }
 
         [Test]
         public void SelfJoinShouldNotThrowException()

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ private class WithContainer`
`107`	`107`
`108`	`108`	`public void AddToCollection(IDictionary<string,object> row)`
`109`	`109`	`{`
	`110`	`+ if (row.All(kvp => ReferenceEquals(null, kvp.Value))) return;`
`110`	`111`	`if (Collection == null) Collection = new HashSet<IDictionary<string, object>>(new DictionaryEqualityComparer());`
`111`	`112`	`Collection.Add(row);`
`112`	`113`	`}`