Skip to content

fix: revert "fix: cannot create root construct in python"#2499

Merged
mergify[bot] merged 3 commits into10.xfrom
revert-2496-mrgrain/fix/python-root-construct
Oct 11, 2024
Merged

fix: revert "fix: cannot create root construct in python"#2499
mergify[bot] merged 3 commits into10.xfrom
revert-2496-mrgrain/fix/python-root-construct

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc commented Oct 11, 2024

Reverts #2496

Seeing failures in AWS CDK reading

warn - METHOD aws-cdk-lib.aws_workspacesweb.CfnPortal.createRoot: has been removed [removed:aws-cdk-lib.aws_workspacesweb.CfnPortal.createRoot]

@mrgrain mrgrain changed the title revert: "fix: cannot create root construct in python" fix: revert: "fix: cannot create root construct in python" Oct 11, 2024
mrgrain
mrgrain reviewed Oct 11, 2024
View reviewed changes
Comment thread src/construct.ts Outdated
mrgrain
mrgrain reviewed Oct 11, 2024
View reviewed changes
Comment thread src/construct.ts Outdated
@mrgrain mrgrain changed the title fix: revert: "fix: cannot create root construct in python" revert: "fix: cannot create root construct in python" Oct 11, 2024
@mrgrain mrgrain changed the title revert: "fix: cannot create root construct in python" fix: revert "fix: cannot create root construct in python" Oct 11, 2024
chore: self mutation
b20729e 
Signed-off-by: github-actions <[email protected]>
@mergify mergify Bot merged commit 3f6a73a into 10.x Oct 11, 2024
@mergify mergify Bot deleted the revert-2496-mrgrain/fix/python-root-construct branch October 11, 2024 19:22
mrgrain added a commit that referenced this pull request Oct 11, 2024
@mrgrain
fix: cannot create root construct in python
7c9289c 
The previous attempt in #2499 caused the static helper to be added to every construct, which was unintentional and caused side-effects. Instead export a class that does the same.

Fixes #1063
@mrgrain mrgrain mentioned this pull request Oct 11, 2024
Merged
mergify Bot pushed a commit that referenced this pull request Oct 14, 2024
@mrgrain
fix: cannot create root construct in python (#2500)
892bb11 
The previous attempt in #2499 caused the static helper to be added to every construct, which was unintentional and caused side-effects. Instead export a class that does the same.

Fixes #1063
@peterboni peterboni mentioned this pull request Nov 2, 2024
Open
@grommir grommir mentioned this pull request Nov 2, 2024
Merged
@gabrieltorreswm gabrieltorreswm mentioned this pull request Nov 3, 2024
Open
@Abisdebra Abisdebra mentioned this pull request Nov 4, 2024
Open
@jsamuel1 jsamuel1 mentioned this pull request Nov 5, 2024
Closed
@kazimanzurrashid kazimanzurrashid mentioned this pull request Nov 5, 2024
Open
@atulgoel126 atulgoel126 mentioned this pull request Nov 7, 2024
Closed
@gentksb gentksb mentioned this pull request Nov 7, 2024
Merged
@ithunter0428 ithunter0428 mentioned this pull request Nov 8, 2024
Open
@bensullivan2002 bensullivan2002 mentioned this pull request Nov 9, 2024
Open
@antonio-marasescu antonio-marasescu mentioned this pull request Nov 10, 2024
Closed
@dependabot dependabot Bot mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaizencc @mrgrain