Skip to content

Incorrect type hint in VerificationSuite.addAnomalyCheck #34

@ashwin153

Description

@ashwin153

Currently, the signature of VerificationSuite.addAnomalyCheck is:

def addAnomalyCheck(self, anomaly, analyzer: AnalysisRunBuilder, anomalyCheckConfig=None):

However, the tests call this function with an analyzer_func such as Size() which is a pydeequ.analyzers._AnalyzerObject. For example,

.addAnomalyCheck(AbsoluteChangeStrategy(maxRateDecrease, maxRateIncrease, order=1), analyzer_func) \

Shouldn't the signature of this method be changed to:

def addAnomalyCheck(self, anomaly, analyzer: _AnalyzerObject, anomalyCheckConfig=None):

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions