Fixed jenkinsci#154

khmarbaise · khmarbaise · commit 0950a65fde70 · 2016-05-03T21:02:10.000+02:00
Fixed jenkinsci#121 Fixed jenkinsci#7 o deleteJob(name), enabledJob(name), disableJob(name), cancelQuietDown(), build(), build(params) producing a HttpResponseException cause by the wrong calling client.post with crumbFlag set to true which was wrong. Changed to false.
diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -5,6 +5,13 @@
 
 ### API Changes
 
+  [deleteJob throws exception but works anyway][issue-154]
+  [Some HTTP calls to jenkins result in a 302, which currently throws an HttpResponseException #7[issue-7]
+  [Create Job is failing - any idea on this error][issue-121]
+  
+  * Fixed. by changing call to client.post(, crumbFlag = true) into
+    client.post(, crumbFlag = false).
+
   [Added getPluginManager() to JenkinsServer][issue-120]
 
 ```java
@@ -309,6 +316,7 @@ TestReport testReport = mavenJob.getLastSuccessfulBuild().getTestReport();
 [2]: https://github.com/RisingOak/jenkins-client/blob/master/src/test/java/com/offbytwo/jenkins/integration/JenkinsLoadStatisticsExample.java
 [3]: https://github.com/RisingOak/jenkins-client/blob/master/src/test/java/com/offbytwo/jenkins/integration/BuildJobTestReports.java
 [4]: https://github.com/RisingOak/jenkins-client/blob/master/src/main/java/com/offbytwo/jenkins/model/Executor.java
+[issue-7]: https://github.com/RisingOak/jenkins-client/issues/7
 [issue-53]: https://github.com/RisingOak/jenkins-client/issues/53
 [issue-67]: https://github.com/RisingOak/jenkins-client/issues/67
 [issue-82]: https://github.com/RisingOak/jenkins-client/issues/82
@@ -320,12 +328,14 @@ TestReport testReport = mavenJob.getLastSuccessfulBuild().getTestReport();
 [issue-108]: https://github.com/RisingOak/jenkins-client/issues/108
 [issue-119]: https://github.com/RisingOak/jenkins-client/issues/119
 [issue-120]: https://github.com/RisingOak/jenkins-client/issues/120
+[issue-121]: https://github.com/RisingOak/jenkins-client/issues/121
 [issue-128]: https://github.com/RisingOak/jenkins-client/issues/128
 [issue-130]: https://github.com/RisingOak/jenkins-client/issues/130
 [issue-133]: https://github.com/RisingOak/jenkins-client/issues/133
 [issue-135]: https://github.com/RisingOak/jenkins-client/issues/135
 [issue-144]: https://github.com/RisingOak/jenkins-client/issues/144
 [issue-146]: https://github.com/RisingOak/jenkins-client/issues/146
+[issue-154]: https://github.com/RisingOak/jenkins-client/issues/154
 [issue-155]: https://github.com/RisingOak/jenkins-client/issues/155
 [pull-123]: https://github.com/RisingOak/jenkins-client/pull/123
 [pull-149]: https://github.com/RisingOak/jenkins-client/pull/149
diff --git a/src/main/java/com/offbytwo/jenkins/client/JenkinsHttpClient.java b/src/main/java/com/offbytwo/jenkins/client/JenkinsHttpClient.java
@@ -431,7 +431,7 @@ public String post_text(String path, String textData, ContentType contentType, b
      *             HttpResponseException
      */
     public void post(String path) throws IOException {
-        post(path, null, null, true);
+        post(path, null, null, false);
     }
 
     public void post(String path, boolean crumbFlag) throws IOException {
diff --git a/src/main/java/com/offbytwo/jenkins/model/Job.java b/src/main/java/com/offbytwo/jenkins/model/Job.java
@@ -68,7 +68,7 @@ public String getFileFromWorkspace(String fileName) throws IOException {
      * Trigger a build without parameters
      */
     public void build() throws IOException {
-        client.post(url + "build", true);
+        client.post(url + "build");
     }
 
     public void build(boolean crumbFlag) throws IOException {
@@ -84,7 +84,7 @@ public void build(boolean crumbFlag) throws IOException {
      */
     public void build(Map<String, String> params) throws IOException {
         String qs = join(Collections2.transform(params.entrySet(), new MapEntryToQueryStringPair()), "&");
-        client.post(url + "buildWithParameters?" + qs, null, null);
+        client.post(url + "buildWithParameters?" + qs);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ public String post_text(String path, String textData, ContentType contentType, b`
`431`	`431`	`* HttpResponseException`
`432`	`432`	`*/`
`433`	`433`	`public void post(String path) throws IOException {`
`434`		`- post(path, null, null, true);`
	`434`	`+ post(path, null, null, false);`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`public void post(String path, boolean crumbFlag) throws IOException {`