Unit tests refactored to check for multiple jobs with names that differ in lower/upper case only

wstrzalka · pnathan · commit 0e07f211af2d · 2016-04-16T11:45:23.000-07:00
diff --git a/src/test/java/com/offbytwo/jenkins/JenkinsServerTest.java b/src/test/java/com/offbytwo/jenkins/JenkinsServerTest.java
@@ -17,6 +17,8 @@
 
 import java.io.IOException;
 import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Map;
 import java.util.UUID;
 
@@ -149,7 +151,7 @@ public void testGetFolderJobInvalidFolder() throws Exception {
 
         given(folderJob.isFolder()).willReturn(false);
         given(client.get(eq(path), eq(FolderJob.class))).willReturn(folderJob);
-
+        
         // when
         Optional<FolderJob> oj = server.getFolderJob(someJob);
 
@@ -181,7 +183,7 @@ public void testCreateSubFolderJob() throws Exception {
         // then
         verify(client).post_form(eq(path + "createItem?"), anyMap(), eq(false));
     }
-
+    
     @Test
     public void testUpdateJobXml() throws Exception {
         // given
@@ -242,7 +244,7 @@ public void testQuietDown() throws IOException {
     @Test
     public void testScriptPosts() throws IOException, URISyntaxException {
         given(client.post_text("/scriptText", "script=script", ContentType.APPLICATION_FORM_URLENCODED, false))
-                .willReturn("result");
+            .willReturn("result");
         String result = server.runScript("script");
         verify(client).post_text("/scriptText", "script=script", ContentType.APPLICATION_FORM_URLENCODED, false);
         assertEquals("result", result);
@@ -253,4 +255,93 @@ public void testJenkinsPathEncoding() throws IOException {
 
         assertEquals("<xml>not a real response</xml>", server.getJobXml("encoded/properly?"));
     }
+
+    private MainView createTestView(List<Job> jobs) {
+        return new MainView(jobs.toArray(new Job[0]));
+    }
+
+    private MainView createTestView(String baseUrl, String... jobNames) {
+        return createTestView(createTestJobs(baseUrl, jobNames));
+    }
+
+    private List<Job> createTestJobs(String baseUrl, String... jobNames) {
+        List<Job> jobs = new ArrayList<Job>();
+        for(String name: jobNames) {
+            jobs.add(new Job(name, baseUrl+name));
+        }
+
+        return jobs;
+    }
+
+
+    @Test
+    public void testReturnSingleJob() throws Exception {
+        shouldReturnListOfJobs("hello");
+    }
+
+    @Test
+    public void testReturnListOfJobs() throws Exception {
+        shouldReturnListOfJobs("hello", "Hello", "HeLLo");
+    }
+
+    @Test
+    public void testFolderGetSingleJob() throws Exception {
+        shouldGetFolderJobs("jobname");
+    }
+
+
+    private void shouldReturnListOfJobs(String...jobNames) throws Exception {
+        MainView mainView = createTestView("http://localhost/job/", jobNames);
+        given(client.get("/", MainView.class)).willReturn(mainView);
+        Map<String, Job> jobs = server.getJobs();
+        for(String name : jobNames)
+            assertTrue(jobs.containsKey(name));
+
+        assertEquals(jobNames.length, jobs.size());
+   }
+
+    @Test
+    public void testGetJobXmls() throws Exception {
+
+        shouldGetJobXml("pr");
+        shouldGetJobXml("hello");
+        shouldGetJobXml("Hello");
+        shouldGetJobXml("HeLLo");
+    }
+
+    private void shouldGetFolderJobs(String... jobNames) throws IOException {
+        // given
+        String path = "http://localhost/jobs/someFolder/";
+        FolderJob folderJob = new FolderJob("someFolder", path);
+
+        List<Job> someJobs = createTestJobs(path, jobNames);
+        MainView mv = createTestView(someJobs);
+
+        given(client.get(eq(path), eq(MainView.class))).willReturn(mv);
+        
+        // when
+        Map<String, Job> map = server.getJobs(folderJob);
+        
+        // then
+        verify(client).get(path, MainView.class);
+
+        for(String name : jobNames)
+            assertTrue(someJobs.contains(map.get(name)));
+
+        assertEquals(jobNames.length, map.size());
+    }
+    private void shouldGetJobXml(String jobName) throws Exception {
+        // given
+        String xmlString = "<xml>some xml goes here</xml>";
+
+        given(client.get(anyString())).willReturn(xmlString);
+
+        // when
+        String xmlReturn = server.getJobXml(jobName);
+
+        // then
+        verify(client).get("/job/"+jobName+"/config.xml");
+        verify(client).get("/job/"+jobName+"/config.xml");
+        assertEquals(xmlString, xmlReturn);
+    }
 }
