Use extension API to open background tabs

muan · muan · commit 66a07edcf325 · 2015-03-06T11:01:13.000-08:00
diff --git a/chrome/src/bg/background.js b/chrome/src/bg/background.js
@@ -11,8 +11,11 @@ request.onload = function() {
 
   chrome.extension.onMessage.addListener(
     function(request, sender, sendMessage) {
-      sendMessage(data)
+      if(request.url) {
+        chrome.tabs.create(request)
+      } else {
+        sendMessage(data)
+      }
     }
   )
 }
-
diff --git a/chrome/src/inject/inject.js b/chrome/src/inject/inject.js
@@ -90,9 +90,9 @@ function initListViewShortcut(regexp) {
 function triggerGitHubLink (backgroundOrNot) {
   // avoid link being appended multiple times
   window.idled = false
-  event = backgroundOrNot ? fakeBackgroundClick() : fakeEvent('click', false)
+  var link = getVisible(document.getElementsByClassName('github-link'))
+  chrome.extension.sendMessage({url: link.href, active: !backgroundOrNot})
 
-  getVisible(document.getElementsByClassName('github-link')).dispatchEvent(event)
   setTimeout( function(){ window.idled = true }, 100)
 }
 
@@ -160,11 +160,6 @@ function fakeEvent (event, bubbles) {
   return click
 }
 
-function fakeBackgroundClick () {
-  var click = new MouseEvent('click', {metaKey: true})
-  return click
-}
-
 function linkWithUrl (url) {
   var l = document.createElement('a')
   l.href = url

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,11 @@ request.onload = function() {`
`11`	`11`
`12`	`12`	`chrome.extension.onMessage.addListener(`
`13`	`13`	`function(request, sender, sendMessage) {`
`14`		`- sendMessage(data)`
	`14`	`+ if(request.url) {`
	`15`	`+ chrome.tabs.create(request)`
	`16`	`+ } else {`
	`17`	`+ sendMessage(data)`
	`18`	`+ }`
`15`	`19`	`}`
`16`	`20`	`)`
`17`	`21`	`}`
`18`		`-`