JAVA-8637: addressing PR review comments.

chaos2418 · chaos2418 · commit 6d824ecf7ccc · 2021-11-23T09:14:57.000+05:30
diff --git a/core-java-modules/core-java-lambdas/src/main/java/com/baeldung/java8/lambda/exceptions/LambdaExceptionWrappers.java b/core-java-modules/core-java-lambdas/src/main/java/com/baeldung/java8/lambda/exceptions/LambdaExceptionWrappers.java
@@ -14,7 +14,7 @@ public static Consumer<Integer> lambdaWrapper(Consumer<Integer> consumer) {
             try {
                 consumer.accept(i);
             } catch (ArithmeticException e) {
-                LOGGER.error("Arithmetic Exception occured : {}", e.getMessage());
+                LOGGER.error("Arithmetic Exception occurred.", e);
             }
         };
     }
@@ -26,7 +26,7 @@ static <T, E extends Exception> Consumer<T> consumerWrapper(Consumer<T> consumer
             } catch (Exception ex) {
                 try {
                     E exCast = clazz.cast(ex);
-                    LOGGER.error("Exception occured : {}", exCast.getMessage());
+                    LOGGER.error("Exception occurred.", exCast);
                 } catch (ClassCastException ccEx) {
                     throw ex;
                 }
@@ -51,7 +51,7 @@ public static <T, E extends Exception> Consumer<T> handlingConsumerWrapper(Throw
             } catch (Exception ex) {
                 try {
                     E exCast = exceptionClass.cast(ex);
-                    LOGGER.error("Exception occured : {}", exCast.getMessage());
+                    LOGGER.error("Exception occurred.", exCast);
                 } catch (ClassCastException ccEx) {
                     throw new RuntimeException(ex);
                 }
diff --git a/persistence-modules/spring-data-jpa-enterprise/src/main/resources/application.properties b/persistence-modules/spring-data-jpa-enterprise/src/main/resources/application.properties
@@ -9,7 +9,7 @@ spring.datasource.url=jdbc:h2:mem:baeldung
 #spring.jpa.properties.javax.persistence.schema-generation.scripts.create-source=metadata
 #spring.jpa.properties.hibernate.format_sql=true
 
-spring.jpa.show-sql=true
+spring.jpa.show-sql=false
 
 #hibernate.dialect=org.hibernate.dialect.H2Dialect
 spring.jpa.properties.hibernate.id.new_generator_mappings=false
diff --git a/persistence-modules/spring-data-jpa-enterprise/src/test/java/com/baeldung/SpringContextTest.java b/persistence-modules/spring-data-jpa-enterprise/src/test/java/com/baeldung/SpringContextTest.java
@@ -10,7 +10,6 @@
 
 @RunWith(SpringRunner.class)
 @SpringBootTest(classes = Application.class)
-@TestPropertySource(properties = {"spring.jpa.show-sql=false "})
 public class SpringContextTest {
 
     @Test
diff --git a/persistence-modules/spring-data-jpa-enterprise/src/test/java/com/baeldung/partialupdate/PartialUpdateUnitTest.java b/persistence-modules/spring-data-jpa-enterprise/src/test/java/com/baeldung/partialupdate/PartialUpdateUnitTest.java
@@ -17,7 +17,6 @@
 
 @RunWith(SpringRunner.class)
 @SpringBootTest(classes = PartialUpdateApplication.class)
-@TestPropertySource(properties = {"spring.jpa.show-sql=false "})
 public class PartialUpdateUnitTest {
 
     @Autowired
diff --git a/spring-caching/src/test/java/com/baeldung/ehcache/SquareCalculatorUnitTest.java b/spring-caching/src/test/java/com/baeldung/ehcache/SquareCalculatorUnitTest.java
@@ -25,23 +25,20 @@ public void setup() {
     @Test
     public void whenCalculatingSquareValueOnce_thenCacheDontHaveValues() {
         for (int i = 10; i < 15; i++) {
-            assertFalse(cacheHelper.getSquareNumberCache()
-                    .containsKey(i));
+            assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));
             LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));
         }
     }
 
     @Test
     public void whenCalculatingSquareValueAgain_thenCacheHasAllValues() {
         for (int i = 10; i < 15; i++) {
-            assertFalse(cacheHelper.getSquareNumberCache()
-                    .containsKey(i));
+            assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));
             LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));
         }
 
         for (int i = 10; i < 15; i++) {
-            assertTrue(cacheHelper.getSquareNumberCache()
-                    .containsKey(i));
+            assertTrue(cacheHelper.getSquareNumberCache().containsKey(i));
             LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i) + "\n");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -25,23 +25,20 @@ public void setup() {`
`25`	`25`	`@Test`
`26`	`26`	`public void whenCalculatingSquareValueOnce_thenCacheDontHaveValues() {`
`27`	`27`	`for (int i = 10; i < 15; i++) {`
`28`		`- assertFalse(cacheHelper.getSquareNumberCache()`
`29`		`- .containsKey(i));`
	`28`	`+ assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));`
`30`	`29`	`LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));`
`31`	`30`	`}`
`32`	`31`	`}`
`33`	`32`
`34`	`33`	`@Test`
`35`	`34`	`public void whenCalculatingSquareValueAgain_thenCacheHasAllValues() {`
`36`	`35`	`for (int i = 10; i < 15; i++) {`
`37`		`- assertFalse(cacheHelper.getSquareNumberCache()`
`38`		`- .containsKey(i));`
	`36`	`+ assertFalse(cacheHelper.getSquareNumberCache().containsKey(i));`
`39`	`37`	`LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i));`
`40`	`38`	`}`
`41`	`39`
`42`	`40`	`for (int i = 10; i < 15; i++) {`
`43`		`- assertTrue(cacheHelper.getSquareNumberCache()`
`44`		`- .containsKey(i));`
	`41`	`+ assertTrue(cacheHelper.getSquareNumberCache().containsKey(i));`
`45`	`42`	`LOGGER.debug("Square value of {} is: {}", i, squaredCalculator.getSquareValueOfNumber(i) + "\n");`
`46`	`43`	`}`
`47`	`44`	`}`