JAVA-9123: POM properties cleanup

kwoyke · kwoyke · commit 70c641eef2a7 · 2022-01-17T14:03:32.000+01:00
diff --git a/axon/pom.xml b/axon/pom.xml
@@ -19,7 +19,7 @@
             <dependency>
                 <groupId>org.axonframework</groupId>
                 <artifactId>axon-bom</artifactId>
-                <version>4.5.0</version>
+                <version>${axon.version}</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
@@ -56,4 +56,8 @@
         </dependency>
     </dependencies>
 
+    <properties>
+        <axon.version>4.5.0</axon.version>
+    </properties>
+
 </project>
diff --git a/core-java-modules/core-java-lang-3/pom.xml b/core-java-modules/core-java-lang-3/pom.xml
@@ -24,7 +24,7 @@
         <dependency>
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-math3</artifactId>
-            <version>3.6.1</version>
+            <version>${commons-math3.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>
@@ -39,4 +39,8 @@
         </resources>
     </build>
 
+    <properties>
+        <commons-math3.version>3.6.1</commons-math3.version>
+    </properties>
+
 </project>
diff --git a/core-java-modules/core-java-lang-math-3/pom.xml b/core-java-modules/core-java-lang-math-3/pom.xml
@@ -17,13 +17,18 @@
         <dependency>
             <groupId>net.objecthunter</groupId>
             <artifactId>exp4j</artifactId>
-            <version>0.4.8</version>
+            <version>${exp4j.version}</version>
         </dependency>
         <dependency>
             <groupId>com.fathzer</groupId>
             <artifactId>javaluator</artifactId>
-            <version>3.0.3</version>
+            <version>${javaluator.version}</version>
         </dependency>
     </dependencies>
 
+    <properties>
+        <exp4j.version>0.4.8</exp4j.version>
+        <javaluator.version>3.0.3</javaluator.version>
+    </properties>
+
 </project>
diff --git a/core-java-modules/core-java-networking-2/pom.xml b/core-java-modules/core-java-networking-2/pom.xml
@@ -37,7 +37,7 @@
         <dependency>
             <groupId>com.icegreen</groupId>
             <artifactId>greenmail</artifactId>
-            <version>1.5.8</version>
+            <version>${greenmail.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>
@@ -50,6 +50,7 @@
         <httpclient.version>4.5.9</httpclient.version>
         <javax.mail.version>1.5.0-b01</javax.mail.version>
         <async-http-client.version>2.4.5</async-http-client.version>
+        <greenmail.version>1.5.8</greenmail.version>
     </properties>
 
 </project>
diff --git a/discord4j/pom.xml b/discord4j/pom.xml
@@ -43,7 +43,7 @@
         <dependency>
             <groupId>com.discord4j</groupId>
             <artifactId>discord4j-core</artifactId>
-            <version>3.1.1</version>
+            <version>${discord4j-core.version}</version>
         </dependency>
     </dependencies>
 
@@ -66,6 +66,7 @@
 
     <properties>
         <java.version>1.8</java.version>
+        <discord4j-core.version>3.1.1</discord4j-core.version>
     </properties>
 
 </project>
diff --git a/libraries-io/pom.xml b/libraries-io/pom.xml
@@ -32,7 +32,7 @@
         <dependency>
             <groupId>net.lingala.zip4j</groupId>
             <artifactId>zip4j</artifactId>
-            <version>2.9.0</version>
+            <version>${zip4j.version}</version>
         </dependency>
     </dependencies>
 
@@ -41,6 +41,7 @@
         <jsch.version>0.1.55</jsch.version>
         <sshj.version>0.27.0</sshj.version>
         <vfs.version>2.4</vfs.version>
+        <zip4j.version>2.9.0</zip4j.version>
     </properties>
 
 </project>
diff --git a/logging-modules/logback/pom.xml b/logging-modules/logback/pom.xml
@@ -17,7 +17,7 @@
         <dependency>
             <groupId>org.json</groupId>
             <artifactId>json</artifactId>
-            <version>20180130</version>
+            <version>${json.version}</version>
         </dependency>
         <dependency>
             <groupId>ch.qos.logback</groupId>
@@ -103,6 +103,7 @@
     </profiles>
 
     <properties>
+        <json.version>20180130</json.version>
         <logback.contrib.version>0.1.5</logback.contrib.version>
         <docx4j.version>3.3.5</docx4j.version>
         <javax.mail.version>1.4.7</javax.mail.version>
diff --git a/lombok/pom.xml b/lombok/pom.xml
@@ -28,7 +28,7 @@
         <dependency>
             <groupId>org.jetbrains</groupId>
             <artifactId>annotations</artifactId>
-            <version>23.0.0</version>
+            <version>${annotations.version}</version>
         </dependency>
     </dependencies>
 
@@ -82,6 +82,7 @@
     <properties>
         <hibernate-jpa-2.1-api.version>1.0.0.Final</hibernate-jpa-2.1-api.version>
         <delombok-maven-plugin.version>1.18.20.0</delombok-maven-plugin.version>
+        <annotations.version>23.0.0</annotations.version>
     </properties>
 
 </project>
diff --git a/netty/pom.xml b/netty/pom.xml
@@ -22,13 +22,14 @@
        <dependency>
             <groupId>org.conscrypt</groupId>
             <artifactId>conscrypt-openjdk-uber</artifactId>
-            <version>2.4.0</version>
+            <version>${conscrypt-openjdk-uber.version}</version>
         </dependency>
 
     </dependencies>
 
     <properties>
         <netty.version>4.1.48.Final</netty.version>
+        <conscrypt-openjdk-uber.version>2.4.0</conscrypt-openjdk-uber.version>
     </properties>
 
 </project>
diff --git a/patterns/enterprise-patterns/pom.xml b/patterns/enterprise-patterns/pom.xml
@@ -29,7 +29,7 @@
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-test</artifactId>
-            <version>2.2.2.RELEASE</version>
+            <version>${spring-boot.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -62,6 +62,7 @@
 
     <properties>
         <camel.version>3.7.4</camel.version>
+        <spring-boot.version>2.2.2.RELEASE</spring-boot.version>
     </properties>
 
 </project>
diff --git a/persistence-modules/spring-data-arangodb/pom.xml b/persistence-modules/spring-data-arangodb/pom.xml
@@ -21,8 +21,12 @@
         <dependency>
             <groupId>com.arangodb</groupId>
             <artifactId>arangodb-spring-data</artifactId>
-            <version>3.5.0</version>
+            <version>${arangodb.version}</version>
         </dependency>
     </dependencies>
 
+    <properties>
+        <arangodb.version>3.5.0</arangodb.version>
+    </properties>
+
 </project>
diff --git a/spring-5-webflux-2/pom.xml b/spring-5-webflux-2/pom.xml
@@ -61,12 +61,12 @@
         <dependency>
             <groupId>io.projectreactor.addons</groupId>
             <artifactId>reactor-extra</artifactId>
-            <version>3.4.5</version>
+            <version>${reactor.version}</version>
         </dependency>
         <dependency>
             <groupId>com.github.ben-manes.caffeine</groupId>
             <artifactId>caffeine</artifactId>
-            <version>2.9.2</version>
+            <version>${caffeine.version}</version>
         </dependency>
         <dependency>
             <groupId>org.springframework.boot</groupId>
@@ -80,7 +80,7 @@
         <dependency>
             <groupId>org.testcontainers</groupId>
             <artifactId>mongodb</artifactId>
-            <version>1.16.2</version>
+            <version>${testcontainers-mongodb.version}</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -98,4 +98,10 @@
         </plugins>
     </build>
 
+    <properties>
+        <reactor.version>3.4.5</reactor.version>
+        <caffeine.version>2.9.2</caffeine.version>
+        <testcontainers-mongodb.version>1.16.2</testcontainers-mongodb.version>
+    </properties>
+
 </project>
diff --git a/spring-boot-modules/spring-boot-2/pom.xml b/spring-boot-modules/spring-boot-2/pom.xml
@@ -35,7 +35,7 @@
         <dependency>
             <groupId>org.springframework</groupId>
             <artifactId>spring-context-indexer</artifactId>
-            <version>5.3.13</version>
+            <version>${spring-core.version}</version>
             <optional>true</optional>
         </dependency>
     </dependencies>
@@ -63,6 +63,7 @@
 
     <properties>
         <log4j2.version>2.14.1</log4j2.version>
+        <spring-core.version>5.3.13</spring-core.version>
         <maven.compiler.target>11</maven.compiler.target>
         <maven.compiler.source>11</maven.compiler.source>
     </properties>
diff --git a/spring-boot-rest-2/pom.xml b/spring-boot-rest-2/pom.xml
@@ -28,7 +28,7 @@
         <dependency>
             <groupId>io.springfox</groupId>
             <artifactId>springfox-boot-starter</artifactId>
-            <version>3.0.0</version>
+            <version>${springfox.version}</version>
         </dependency>
         <dependency>
             <groupId>org.springframework.boot</groupId>
@@ -50,4 +50,8 @@
         </plugins>
     </build>
 
+    <properties>
+        <springfox.version>3.0.0</springfox.version>
+    </properties>
+
 </project>
diff --git a/spring-core-4/pom.xml b/spring-core-4/pom.xml
@@ -64,7 +64,7 @@
         <dependency>
             <groupId>javax.servlet</groupId>
             <artifactId>javax.servlet-api</artifactId>
-            <version>4.0.0</version>
+            <version>${servlet-api.version}</version>
         </dependency>
     </dependencies>
 
@@ -73,6 +73,7 @@
         <spring.boot.version>2.2.2.RELEASE</spring.boot.version>
         <guava.version>28.2-jre</guava.version>
         <awaitility.version>4.0.2</awaitility.version>
+        <servlet-api.version>4.0.0</servlet-api.version>
     </properties>
 
 </project>
diff --git a/spring-security-modules/spring-security-web-boot-3/pom.xml b/spring-security-modules/spring-security-web-boot-3/pom.xml
@@ -26,7 +26,7 @@
         <dependency>
             <groupId>commons-io</groupId>
             <artifactId>commons-io</artifactId>
-            <version>2.11.0</version>
+            <version>${commons-io.version}</version>
         </dependency>
         <dependency>
             <groupId>org.webjars</groupId>
@@ -35,12 +35,12 @@
         <dependency>
             <groupId>org.webjars</groupId>
             <artifactId>bootstrap</artifactId>
-            <version>5.1.1</version>
+            <version>${bootstrap.version}</version>
         </dependency>
         <dependency>
             <groupId>org.webjars</groupId>
             <artifactId>jquery</artifactId>
-            <version>3.6.0</version>
+            <version>${jquery.version}</version>
         </dependency>
         <dependency>
             <groupId>org.springframework.boot</groupId>
@@ -58,4 +58,10 @@
         </dependency>
     </dependencies>
 
+    <properties>
+        <bootstrap.version>5.1.1</bootstrap.version>
+        <jquery.version>3.6.0</jquery.version>
+    </properties>
+
+
 </project>
