Updated/removed pending specs

zph · zph · commit d9ab717ed32a · 2013-05-25T23:52:22.000-04:00
diff --git a/lib/buff/update.rb b/lib/buff/update.rb
@@ -19,6 +19,7 @@ def updates_by_profile_id(id, options={})
       end
 
       def interactions_by_update_id(id, options={})
+        check_id(id)
         response = get("/updates/#{id}/interactions.json", options)
         interactions = response['interactions'].map { |r| Buff::Interaction.new(r) }
         Buff::Interactions.new(
diff --git a/spec/lib/buff/schedule_spec.rb b/spec/lib/buff/schedule_spec.rb
@@ -68,7 +68,8 @@
   end
 
   describe "#set_schedules" do
-    xit "throw error if schedules is empty" do
+    let(:id) { "5160746d54f04a5e3a00000f" }
+    it "throw error if schedules is empty" do
       lambda {
         Buff::Client.new("some_token").set_schedules(id) }.
       should raise_error(ArgumentError)
diff --git a/spec/lib/buff/update_spec.rb b/spec/lib/buff/update_spec.rb
@@ -60,14 +60,20 @@
     end
 
     describe "#interactions_by_update_id" do
-      xit "requires an id"
-      xit "connects to the correct endpoint"
-      xit "returns an object where total is accessible"
-      it "allows optional params" do
-        url = "https://api.bufferapp.com/1/updates/4ecda476542f7ee521000006/interactions.json?access_token=some_token&page=2"
-        id = "4ecda476542f7ee521000006"
+      let(:url) { "https://api.bufferapp.com/1/updates/4ecda476542f7ee521000006/interactions.json?access_token=some_token&page=2" }
+      let(:id) { "4ecda476542f7ee521000006" }
+
+      before do
         stub_request(:get, url).
           to_return(fixture("interactions_by_update_id.txt"))
+      end
+
+      it "requires an id" do
+        lambda { client.interactions_by_update_id(page: 2) }.
+          should raise_error(Buff::InvalidIdLength)
+      end
+
+      it "allows optional params" do
         client.interactions_by_update_id(id, page: 2)
       end
     end
diff --git a/spec/lib/core_spec.rb b/spec/lib/core_spec.rb
@@ -35,19 +35,14 @@
          should eq(true)
     end
 
-    xit "does not delegate to #handle_response_code when code = 200" do
+    it "does not delegate to #handle_response_code when code = 200" do
       url = "#{base_path}/info/configuration.json"
       fixture_name = "link.txt"
       stub_with_to_return(:get, url, fixture_name)
        client.should_not_receive(:handle_response_code)
        client.info
     end
 
-    xit "transforms sample_schedule into correct formatted url" do
-      u = Addressable::URI.new
-      u.query_values = {schedules: sample_schedules[0]}
-      u.query.should eq(post_data)
-    end
   end
 
   describe "#handle_response_code" do
