Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hardbyte/python-can
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bures/python-can
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 4, 2024

  1. When there is an invalid frame on CAN bus (in our case CAN FD), PCAN …

    …first reports result PCAN_ERROR_ILLDATA and then it send the error frame. If the PCAN_ERROR_ILLDATA is not ignored, python-can throws an exception.
    
    This fix add the ignore on the PCAN_ERROR_ILLDATA.
    bures committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2ec8ac2 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fix for ruff error `can/interfaces/pcan/pcan.py:5:1: I001 [*] Import …

    …block is un-sorted or un-formatted`
    
    Added comment explaining why to ignore the PCAN_ERROR_ILLDATA.
    bures committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6e7ad06 View commit details
    Browse the repository at this point in the history
Loading