Add not found exception (#118)

sebastiansimson · web-flow · commit d5b689b3d26d · 2022-05-20T09:32:33.000+02:00
diff --git a/src/main/java/io/castle/client/internal/utils/OkHttpExceptionUtil.java b/src/main/java/io/castle/client/internal/utils/OkHttpExceptionUtil.java
@@ -18,20 +18,22 @@ public static CastleRuntimeException handle(IOException e) {
 
     public static void handle(Response response) throws CastleServerErrorException {
         if (!response.isSuccessful() && !response.isRedirect()) {
-            if (response.code() == 500) {
-                throw new CastleApiInternalServerErrorException(response);
-            }
-            if (response.code() == 422) {
-                try {
-                    String body = response.peekBody(Long.MAX_VALUE).string();
-                    JsonObject json = (JsonObject) JsonParser.parseString(body);
-                    String type = json.get("type").getAsString();
+            switch (response.code()) {
+                case 500:
+                    throw new CastleApiInternalServerErrorException(response);
+                case 422:
+                    try {
+                        String body = response.peekBody(Long.MAX_VALUE).string();
+                        JsonObject json = (JsonObject) JsonParser.parseString(body);
+                        String type = json.get("type").getAsString();
 
-                    if (type.equals("invalid_request_token")) {
-                        throw new CastleApiInvalidRequestTokenException(response);
-                    }
-                } catch (IOException | JsonSyntaxException | JsonIOException | IllegalStateException ignored) {}
-                throw new CastleApiInvalidParametersException(response);
+                        if (type.equals("invalid_request_token")) {
+                            throw new CastleApiInvalidRequestTokenException(response);
+                        }
+                    } catch (IOException | JsonSyntaxException | JsonIOException | IllegalStateException ignored) {}
+                    throw new CastleApiInvalidParametersException(response);
+                case 404:
+                    throw new CastleApiNotFoundException(response);
             }
             throw new CastleServerErrorException(response);
         }
diff --git a/src/main/java/io/castle/client/model/CastleApiNotFoundException.java b/src/main/java/io/castle/client/model/CastleApiNotFoundException.java
@@ -0,0 +1,10 @@
+package io.castle.client.model;
+
+import io.castle.client.model.CastleServerErrorException;
+import okhttp3.Response;
+
+public class CastleApiNotFoundException extends CastleServerErrorException {
+    public CastleApiNotFoundException(Response response) {
+        super(response);
+    }
+}
diff --git a/src/test/java/io/castle/client/CastleExceptionTest.java b/src/test/java/io/castle/client/CastleExceptionTest.java
@@ -119,4 +119,17 @@ public void invalidJsonError() {
 
         OkHttpExceptionUtil.handle(response);
     }
+
+    @Test(expected = CastleApiNotFoundException.class)
+    public void notFoundError() {
+        //Given
+        Response response = new Response.Builder()
+                .code(404)
+                .request(new Request.Builder().url("http://localhost").build())
+                .protocol(Protocol.HTTP_1_1)
+                .message("Message")
+                .build();
+
+        OkHttpExceptionUtil.handle(response);
+    }
 }
