Merge pull request #1 from orinamio/improve-submit-button

orinamio · web-flow · commit dc5366154cdd · 2022-11-25T07:33:36.000+04:00
refactor: use correct prop typing for SubmitButton text input props
diff --git a/README.md b/README.md
@@ -78,9 +78,11 @@ export default function App() {
         </View>
 
         <SubmitButton
-          title="Pay Now"
           style={styles.button}
-          textStyle={styles.buttonText}
+          textInputProps={{
+            title: "Pay Now",
+            style: styles.buttonText,
+          }}
           onPress={() => console.log("merchant action")}
         />
       </Frames>
diff --git a/src/components/SubmitButton.tsx b/src/components/SubmitButton.tsx
@@ -11,7 +11,8 @@ const SubmitButton: React.FunctionComponent<SubmitButtonProps> = (props) => {
           throw "It looks like you are trying to render the SubmitButton outside of the Frames Component.";
         }
 
-        const { textStyle: textStyle, title: title, ...touchableProps } = props;
+        const { textInputProps = {}, ...touchableProps } = props;
+        const { title } = textInputProps;
 
         return (
           <TouchableOpacity
@@ -22,7 +23,7 @@ const SubmitButton: React.FunctionComponent<SubmitButtonProps> = (props) => {
               if (props.onPress) props.onPress(e);
             }}
           >
-            <Text style={[styles.buttonText, textStyle]}>{title}</Text>
+            <Text {...textInputProps}  style={[styles.buttonText, textInputProps.style]}>{title}</Text>
           </TouchableOpacity>
         );
       }}
diff --git a/src/types/types.tsx b/src/types/types.tsx
@@ -194,6 +194,5 @@ export interface CardBinChangedEvent {
 }
 
 export interface SubmitButtonProps extends TouchableOpacityProps {
-  title: string;
-  textStyle?: TextProps;
+  textInputProps?: TextInputProps;
 }

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,5 @@ export interface CardBinChangedEvent {`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`export interface SubmitButtonProps extends TouchableOpacityProps {`
`197`		`- title: string;`
`198`		`- textStyle?: TextProps;`
	`197`	`+ textInputProps?: TextInputProps;`
`199`	`198`	`}`