-
Notifications
You must be signed in to change notification settings - Fork 37
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: code-squad/javascript-polygon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: code-squad/javascript-polygon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: wo0kgod
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 4 files changed
- 5 contributors
Commits on Nov 13, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9d32c1b - Browse repository at this point
Copy the full SHA 9d32c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for df49a52 - Browse repository at this point
Copy the full SHA df49a52View commit details
Commits on Nov 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 1aded7f - Browse repository at this point
Copy the full SHA 1aded7fView commit details
Commits on Nov 15, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a65d294 - Browse repository at this point
Copy the full SHA a65d294View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea3f230 - Browse repository at this point
Copy the full SHA ea3f230View commit details -
Merge pull request #5 from hannarita/hannarita
Hannarita/다각형의 넓이 구하는 함수 만들기 완료
Configuration menu - View commit details
-
Copy full SHA for 4ca045a - Browse repository at this point
Copy the full SHA 4ca045aView commit details
Commits on Sep 14, 2018
-
* 1차 다각형넓이구하기 * 1.함수명 변경 2.숫자판별을 함수가 아닌 개별 함수내의 조건으로 재설정 3.let pi > const pi 4.return 오류 수정
Configuration menu - View commit details
-
Copy full SHA for 095706e - Browse repository at this point
Copy the full SHA 095706eView commit details -
* 다각형 넓이 (#29) * index of polygonSize * Full index of html and get area of circle, square, trapezoid, cylinder * restart * add sizeCircle function * add function sizeSquare, add testcode * add function sizeTrapezoid, add test code * add function sizeSylinder, add distinguish test code, add test code * modify by referring to feedback, add function getArea, add function printExecutionSequence * Revise var to const, Change variable name arr -> ExecutionSequenceArray, and Revise PrintExecutionSequence function(revise forEach method to use arrow function), * revise isNum function to use 'for' statement and add typenumberfunction for isNum function * modifiy function sizeCircle to CalcCircleWidth and change inner contents * Modify sizeSquare function to CalcRectWidth and change inner contents * Modify sizeTrapezoid function to calcTrapezoidWidth function and revise inner contents * Modify sizeSylinder functino to calcSylinderWidth function and revise inner context * Modify getArea function to check Number of arguments * Revise little bugs,(add return to calcSylinderWidth, change some upperCase to lowerCase
Configuration menu - View commit details
-
Copy full SHA for 97ff01e - Browse repository at this point
Copy the full SHA 97ff01eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d51bb30 - Browse repository at this point
Copy the full SHA d51bb30View commit details
Commits on Apr 12, 2019
-
step 2-2 feat: 출력함수구현, refactor: switch문 객체로 수정 (#88)
* feat: add polygon-calculator app.js - 실행 파일 calc.js - 계산 관련 함수 check.js - validate 관련 함수 * feat&refactor : add printExecutionSequence , change switch -> object sequence 변수를 만들고 getArea에서 push를 하고 나중에 출력하도록 하였습니다. 이때 sequence 변수는 객체의 속성으로 정의하였습니다. switch문 대신에 polygonAreaFunction 객체를 만들고 getArea에서 입력받은 문장을 key값으로 , value는 함수를 연결하였습니다. 출력해주는 printExecutionSequence 함수에서 값의 변경을 용이하게 하기 위해 객체로 값을 넘겨주었습니다.
Configuration menu - View commit details
-
Copy full SHA for 9807fb7 - Browse repository at this point
Copy the full SHA 9807fb7View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...wo0kgod