forked from demisto/content
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathutils_test.py
More file actions
492 lines (408 loc) · 14.7 KB
/
utils_test.py
File metadata and controls
492 lines (408 loc) · 14.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
#!/usr/bin/env python3
import json
from pathlib import Path
import pytest
import requests_mock
from typing import Any
from utils import (
get_env_var,
EnvVariableError,
get_content_reviewers,
CONTRIBUTION_REVIEWERS_KEY,
CONTRIBUTION_SECURITY_REVIEWER_KEY,
TIM_REVIEWER_KEY,
DOC_REVIEWER_KEY,
get_doc_reviewer,
CONTENT_ROLES_BLOB_MASTER_URL,
get_content_roles,
CONTENT_ROLES_FILENAME,
GITHUB_HIDDEN_DIR,
)
from git import Repo
class TestGetEnvVar:
def test_no_env_var(self):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable does not exist
- No 'default_val' argument was passed when the function was called
Then
- Ensure a 'EnvVariableError' exception is raised
"""
with pytest.raises(EnvVariableError):
get_env_var("MADE_UP_ENV_VARIABLE")
def test_empty_env_var(self, monkeypatch):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable's value is an empty string
- No 'default_val' argument was passed when the function was called
Then
- Ensure a 'EnvVariableError' exception is raised
"""
monkeypatch.setenv("MADE_UP_ENV_VARIABLE", "")
with pytest.raises(EnvVariableError):
get_env_var("MADE_UP_ENV_VARIABLE")
def test_no_env_var_with_default(self):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable does not exist
- The 'default_val' argument was passed with a value of 'TIMOTHY'
Then
- Ensure 'TIMOTHY' is returned from the function
"""
default_val = "TIMOTHY"
env_var_val = get_env_var("MADE_UP_ENV_VARIABLE", default_val)
assert env_var_val == default_val
def test_empty_env_var_with_default(self, monkeypatch):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable's value is an empty string
- The 'default_val' argument was passed with a value of 'TIMOTHY'
Then
- Ensure 'TIMOTHY' is returned from the function
"""
monkeypatch.setenv("MADE_UP_ENV_VARIABLE", "")
default_val = "TIMOTHY"
env_var_val = get_env_var("MADE_UP_ENV_VARIABLE", default_val)
assert env_var_val == default_val
def test_existing_env_var(self, monkeypatch):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable's value is 'LEROY JENKINS'
- No 'default_val' argument was passed when the function was called
Then
- Ensure 'LEROY JENKINS' is returned from the function
"""
monkeypatch.setenv("MADE_UP_ENV_VARIABLE", "LEROY JENKINS")
env_var_val = get_env_var("MADE_UP_ENV_VARIABLE")
assert env_var_val == "LEROY JENKINS"
def test_existing_env_var_with_default(self, monkeypatch):
"""
Scenario: Try getting an environment variable
Given
- Using the 'get_env_var' function
When
- The environment variable's value is 'LEROY JENKINS'
- The 'default_val' argument was passed with a value of 'TIMOTHY'
Then
- Ensure 'LEROY JENKINS' is returned from the function
"""
monkeypatch.setenv("MADE_UP_ENV_VARIABLE", "LEROY JENKINS")
default_val = "TIMOTHY"
env_var_val = get_env_var("MADE_UP_ENV_VARIABLE", default_val)
assert env_var_val == "LEROY JENKINS"
@pytest.mark.parametrize(
"content_roles,expected_content_reviewers,expected_security_reviewer, expected_tim_reviewer",
[
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1", "cr2", "cr3", "cr4"],
CONTRIBUTION_SECURITY_REVIEWER_KEY: ["sr1"],
TIM_REVIEWER_KEY: "tr1",
"CONTRIBUTION_TL": "tl1",
"ON_CALL_DEVS": ["ocd1", "ocd2"],
},
["cr1", "cr2", "cr3", "cr4"],
["sr1"],
"tr1",
),
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1", "cr2", "cr3", "cr4"],
CONTRIBUTION_SECURITY_REVIEWER_KEY: [""],
TIM_REVIEWER_KEY: "tr1",
"CONTRIBUTION_TL": "tl1",
"ON_CALL_DEVS": ["ocd1", "ocd2"],
},
["cr1", "cr2", "cr3", "cr4"],
[""],
"tr1",
),
],
)
def test_get_content_reviewers(
content_roles: dict[str, Any],
expected_content_reviewers: list[str],
expected_security_reviewer: str,
expected_tim_reviewer: str,
):
"""
Test retrieval of content and security reviewers.
Given:
- A ``dict[str, Any]``
When:
- 4 content reviewers and 1 security reviewers provided
Then:
- 4 content reviewers and 1 security reviewer added
"""
actual_content_reviewers, actual_security_reviewer, actual_tim_reviewer = get_content_reviewers(content_roles)
assert actual_content_reviewers == expected_content_reviewers
assert actual_security_reviewer == expected_security_reviewer
assert actual_tim_reviewer == expected_tim_reviewer
@pytest.mark.parametrize(
"content_roles,expected_content_reviewers,expected_security_reviewer, expected_tim_reviewer",
[
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1", "cr2", "cr3", "cr4"],
CONTRIBUTION_SECURITY_REVIEWER_KEY: ["sr1", "sr2"],
TIM_REVIEWER_KEY: "tr1",
"CONTRIBUTION_TL": "tl1",
"ON_CALL_DEVS": ["ocd1", "ocd2"],
},
["cr1", "cr2", "cr3", "cr4"],
["sr1", "sr2"],
"tr1",
)
],
)
def test_get_content_reviewers_multiple_security(
content_roles: dict[str, Any],
expected_content_reviewers: list[str],
expected_security_reviewer: str,
expected_tim_reviewer: str,
):
"""
Test retrieval of content and security reviewers.
Given:
- A ``dict[str, Any]``
When:
- 4 content reviewers and 1 security reviewers provided
Then:
- 4 content reviewers and 1 security reviewer added
"""
actual_content_reviewers, actual_security_reviewer, actual_tim_reviewer = get_content_reviewers(content_roles)
assert actual_content_reviewers == expected_content_reviewers
assert actual_security_reviewer == expected_security_reviewer
assert actual_tim_reviewer == expected_tim_reviewer
@pytest.mark.parametrize(
"content_roles",
[
(
{
CONTRIBUTION_REVIEWERS_KEY: [],
CONTRIBUTION_SECURITY_REVIEWER_KEY: "sr1",
}
),
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1", "cr2"],
CONTRIBUTION_SECURITY_REVIEWER_KEY: None,
}
),
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1", "cr2"],
CONTRIBUTION_SECURITY_REVIEWER_KEY: "",
}
),
(
{
CONTRIBUTION_REVIEWERS_KEY: "sr1",
CONTRIBUTION_SECURITY_REVIEWER_KEY: "cr1",
}
),
(
{
CONTRIBUTION_SECURITY_REVIEWER_KEY: ["sr1"],
}
),
(
{
CONTRIBUTION_REVIEWERS_KEY: ["cr1"],
}
),
({"CONTRIBUTION_TL": "tl1", "ON_CALL_DEVS": ["ocd1", "ocd2"]}),
],
)
def test_exit_get_content_reviewers(content_roles: dict[str, Any]):
"""
Test retrieval of content and security reviewers when the file/`dict`
has unexpected/incorrect structure.
Given:
- A ``dict[str, Any]``
When:
- Case A: An empty contribution reviewers `list` is supplied.
- Case B: An undefined security reviewer is supplied.
- Case C: An empty security reviewer is supplied.
- Case D: A `str` is supplied for the contribution reviewers.
- Case E: No contribution reviewers key is supplied.
- Case F: No security reviewer key is supplied.
- Case G: No security reviewer key nor contribution reviewers key is supplied.
Then:
- Case A-G: Result in `sys.exit(1)`.
"""
with pytest.raises(SystemExit) as e:
get_content_reviewers(content_roles)
assert e.type is SystemExit
assert e.value.code == 1
@pytest.mark.parametrize(
"content_roles,expected_doc_reviewer",
[
(
{
"CONTRIBUTION_REVIEWERS": ["cr1", "cr2", "cr3", "cr4"],
"CONTRIBUTION_SECURITY_REVIEWER": "sr1",
"CONTRIBUTION_TL": "tl1",
"ON_CALL_DEVS": ["ocd1", "ocd2"],
DOC_REVIEWER_KEY: "dr1",
},
"dr1",
)
],
)
def test_get_doc_reviewer(content_roles: dict[str, Any], expected_doc_reviewer: str):
"""
Test retrieval of doc reviewer.
Given:
- A ``dict[str, Any]``
When:
- Case A: 4 content reviewers and 1 security reviewers provided, 1 doc reviewer
- Case B: There's no ``DOC_REVIEWER`` key in `dict`.
Then:
- Case A: 1 doc reviewer returned.
- Case B: `None`.
"""
actual_doc_reviewer = get_doc_reviewer(content_roles)
assert actual_doc_reviewer == expected_doc_reviewer
@pytest.mark.parametrize(
"content_roles",
[
(
{
DOC_REVIEWER_KEY: [],
}
),
(
{
"CONTRIBUTION_REVIEWERS": ["cr1", "cr2"],
}
),
({DOC_REVIEWER_KEY: ""}),
({DOC_REVIEWER_KEY: None}),
],
)
def test_exit_get_doc_reviewer(content_roles: dict[str, Any]):
"""
Test retrieval of content and security reviewers when the file/`dict`
has unexpected/incorrect structure.
Given:
- A ``dict[str, Any]``
When:
- Case A: Document reviewer specified as an array/list.
- Case B: Document reviewer key is not specified.
- Case C: Document reviewer is empty.
- Case D: Document reviewer is undefined.
Then:
- Case A-G: Result in `sys.exit(1)`.
"""
with pytest.raises(ValueError) as e:
get_doc_reviewer(content_roles)
assert e.type is ValueError
class TestGetContentRoles:
content_roles: dict[str, Any] = {
CONTRIBUTION_REVIEWERS_KEY: ["prr1", "prr2", "prr3"],
"CONTRIBUTION_TL": "tl1",
CONTRIBUTION_SECURITY_REVIEWER_KEY: "sr1",
"ON_CALL_DEVS": ["ocd1", "ocd2"],
DOC_REVIEWER_KEY: "dr1",
TIM_REVIEWER_KEY: "tr1",
}
def test_get_content_roles_success(self, requests_mock: requests_mock.Mocker):
"""
Test successful retrieval of content_roles.json.
Given:
- A content_roles.json
When:
- The request to retrieve content_roles.json is successful.
Then:
- The response includes the expected content role keys.
"""
requests_mock.get(CONTENT_ROLES_BLOB_MASTER_URL, json=self.content_roles)
actual_content_roles = get_content_roles()
assert actual_content_roles
assert CONTRIBUTION_REVIEWERS_KEY in actual_content_roles
assert CONTRIBUTION_SECURITY_REVIEWER_KEY in actual_content_roles
assert TIM_REVIEWER_KEY in actual_content_roles
def test_get_content_roles_fail_blob(self, requests_mock: requests_mock.Mocker, tmp_path: Path):
"""
Test failure to retrieve the content_roles.json blob
and successful retrieval from the filesystem.
Given:
- A content_roles.json
When:
- The request to retrieve content_roles.json is fails.
Then:
- get_content_roles returns a populated dict.
"""
# Mock failed request
requests_mock.get(CONTENT_ROLES_BLOB_MASTER_URL, status_code=404)
# Create repo and content_roles.json in fs
Repo.init(tmp_path)
(tmp_path / GITHUB_HIDDEN_DIR).mkdir()
content_roles_path = tmp_path / GITHUB_HIDDEN_DIR / CONTENT_ROLES_FILENAME
content_roles_path.touch()
content_roles_path.write_text(json.dumps(self.content_roles, indent=4))
actual_content_roles = get_content_roles(tmp_path)
assert actual_content_roles
assert CONTRIBUTION_REVIEWERS_KEY in actual_content_roles
assert CONTRIBUTION_SECURITY_REVIEWER_KEY in actual_content_roles
assert TIM_REVIEWER_KEY in actual_content_roles
def test_get_content_roles_invalid_json_blob(self, requests_mock: requests_mock.Mocker, tmp_path: Path):
"""
Test failure to retrieve content_roles.json
and successful retrieval from the filesystem.
Given:
- A content_roles.json
When:
- The content_roles.json is invalid.
Then:
- get_content_roles returns a populated dict.
"""
requests_mock.get(CONTENT_ROLES_BLOB_MASTER_URL, json={"only_key"})
# Create repo and content_roles.json in fs
Repo.init(tmp_path)
(tmp_path / GITHUB_HIDDEN_DIR).mkdir()
content_roles_path = tmp_path / GITHUB_HIDDEN_DIR / CONTENT_ROLES_FILENAME
content_roles_path.touch()
content_roles_path.write_text(json.dumps(self.content_roles, indent=4))
actual_content_roles = get_content_roles(tmp_path)
assert actual_content_roles
assert CONTRIBUTION_REVIEWERS_KEY in actual_content_roles
assert CONTRIBUTION_SECURITY_REVIEWER_KEY in actual_content_roles
assert TIM_REVIEWER_KEY in actual_content_roles
def test_get_content_roles_invalid_json_blob_and_fs(self, requests_mock: requests_mock.Mocker, tmp_path: Path):
"""
Test failure to retrieve content_roles.json
from the blob and from the filesystem.
Given:
- A content_roles.json
When:
- The content_roles.json is invalid in blob.
- The content_roles.json is invalid in filesystem.
Then:
- get_content_roles returns nothing.
"""
requests_mock.get(CONTENT_ROLES_BLOB_MASTER_URL, json={"only_key"})
# Create repo and content_roles.json in fs
Repo.init(tmp_path)
(tmp_path / GITHUB_HIDDEN_DIR).mkdir()
content_roles_path = tmp_path / GITHUB_HIDDEN_DIR / CONTENT_ROLES_FILENAME
content_roles_path.touch()
content_roles_path.write_text('{"only_key"}')
actual_content_roles = get_content_roles(tmp_path)
assert not actual_content_roles