Change specs to stop using global namespace and change code formatting.

piotrmurach · piotrmurach · commit 1d91d06623ab · 2017-04-12T22:13:13.000+01:00
diff --git a/spec/unit/client/projects/cards/create_spec.rb b/spec/unit/client/projects/cards/create_spec.rb
@@ -14,9 +14,9 @@
 
   before do
     subject.oauth_token = OAUTH_TOKEN
-    stub_post(request_path).with(body: inputs)
-                           .to_return(body: body, status: status,
-                                      headers: { content_type: "application/json; charset=utf-8" })
+    stub_post(request_path).with(body: inputs).
+      to_return(body: body, status: status,
+                headers: { content_type: "application/json; charset=utf-8" })
   end
 
   after { reset_authentication_for subject }
@@ -28,17 +28,17 @@
     context "for the authenticated user" do
       let(:request_path) { "/projects/columns/#{column_id}/cards?access_token=#{OAUTH_TOKEN}" }
 
-      it "should create resource" do
+      it "creates resource" do
         subject.create column_id, inputs
         a_post(request_path).with(body: inputs).should have_been_made
       end
 
-      it "should return the resource" do
+      it "returns the resource" do
         card = subject.create column_id, inputs
         expect(card.note).to eq 'Add payload for delete Project column'
       end
 
-      it "should return mash type" do
+      it "returns mash type" do
         card = subject.create column_id, inputs
         expect(card).to be_a Github::ResponseWrapper
       end
diff --git a/spec/unit/client/projects/cards/delete_spec.rb b/spec/unit/client/projects/cards/delete_spec.rb
@@ -2,27 +2,28 @@
 
 require 'spec_helper'
 
-describe Github::Client::Projects::Cards, '#delete' do
+RSpec.describe Github::Client::Projects::Cards, '#delete' do
   let(:card_id) { 1478 }
   let(:request_path) { "/projects/columns/cards/#{card_id}" }
   let(:body) { '' }
   let(:status) { 204 }
 
   before do
-    stub_delete(request_path).to_return(body: body, status: status,
-                                        headers: { content_type: "application/json; charset=utf-8" })
+    stub_delete(request_path).
+      to_return(body: body, status: status,
+                headers: { content_type: "application/json; charset=utf-8" })
   end
 
   after { reset_authentication_for subject }
 
   it { expect(subject).to respond_to :remove }
 
-  it "should delete the resource successfully" do
+  it "deletes the resource successfully" do
     subject.delete card_id
     expect(a_delete(request_path)).to have_been_made
   end
 
-  it "should fail to delete resource without 'id' parameter" do
+  it "fails to delete resource without 'id' parameter" do
     expect { subject.delete }.to raise_error(ArgumentError)
   end
 
diff --git a/spec/unit/client/projects/cards/get_spec.rb b/spec/unit/client/projects/cards/get_spec.rb
@@ -9,8 +9,9 @@
   let(:status) { 200 }
 
   before do
-    stub_get(request_path).to_return(body: body, status: status,
-                                     headers: { content_type: "application/json; charset=utf-8" })
+    stub_get(request_path).
+      to_return(body: body, status: status,
+                headers: { content_type: "application/json; charset=utf-8" })
   end
 
   after { reset_authentication_for(subject) }
diff --git a/spec/unit/client/projects/cards/list_spec.rb b/spec/unit/client/projects/cards/list_spec.rb
@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Github::Client::Projects::Cards, '#list' do
+RSpec.describe Github::Client::Projects::Cards, '#list' do
   let(:column_id) { 367 }
   let(:request_path) { "/projects/columns/#{column_id}/cards" }
 
diff --git a/spec/unit/client/projects/cards/move_spec.rb b/spec/unit/client/projects/cards/move_spec.rb
@@ -1,31 +1,31 @@
+# encoding: utf-8
 # frozen_string_literal: true
 
 require 'spec_helper'
 
-describe Github::Client::Projects::Cards, '#move' do
+RSpec.describe Github::Client::Projects::Cards, '#move' do
   let(:card_id) { 1478 }
   let(:request_path) { "/projects/columns/cards/#{card_id}/moves" }
   let(:body) { '' }
   let(:status) { 204 }
   let(:inputs) do
-    {
-      position: "after:3"
-    }
+    { position: "after:3" }
   end
 
   before do
-    stub_post(request_path).with(body: inputs.to_json).to_return(body: body, status: status,
-                                                                 headers: { content_type: "application/json; charset=utf-8" })
+    stub_post(request_path).with(body: inputs.to_json).
+      to_return(body: body, status: status,
+                headers: { content_type: "application/json; charset=utf-8" })
   end
 
   after { reset_authentication_for subject }
 
-  it "should move the resource successfully" do
+  it "moves the resource successfully" do
     subject.move card_id, inputs
     expect(a_post(request_path)).to have_been_made
   end
 
-  it "should fail to move resource without 'id' parameter" do
+  it "fails to move resource without 'id' parameter" do
     expect { subject.move inputs }.to raise_error(ArgumentError)
   end
 
diff --git a/spec/unit/client/projects/cards/update_spec.rb b/spec/unit/client/projects/cards/update_spec.rb
@@ -14,9 +14,9 @@
   end
 
   before do
-    stub_patch(request_path).with(body: inputs)
-                            .to_return(body: body, status: status,
-                                       headers: { content_type: 'application/json; charset=utf-8' })
+    stub_patch(request_path).with(body: inputs).
+      to_return(body: body, status: status,
+                headers: { content_type: 'application/json; charset=utf-8' })
   end
 
   after { reset_authentication_for(subject) }
