Merge pull request piotrmurach#319 from olleolleolle/fix/avoid-warnings-when-running-specs

piotrmurach · web-flow · commit d51f45a8784b · 2017-07-14T21:43:25.000+01:00
Avoid Ruby warnings
diff --git a/lib/github_api/api.rb b/lib/github_api/api.rb
@@ -24,9 +24,9 @@ class API
     include Request::Verbs
     include RateLimit
 
-    attr_reader *Github.configuration.property_names
+    attr_reader(*Github.configuration.property_names)
 
-    attr_accessor *Validations::VALID_API_KEYS
+    attr_accessor(*Validations::VALID_API_KEYS)
 
     attr_accessor :current_options
 
@@ -209,7 +209,7 @@ def self.method_added(method_name)
     #
     # @api private
     def filter_callbacks(kind, action_name)
-      matched_callbacks = self.class.send("#{kind}_callbacks").select do |callback|
+      self.class.send("#{kind}_callbacks").select do |callback|
         callback[:only].nil? || callback[:only].include?(action_name)
       end
     end
diff --git a/lib/github_api/client/authorizations/app.rb b/lib/github_api/client/authorizations/app.rb
@@ -47,7 +47,7 @@ def check(*args)
       if arguments.client_id
         begin
           get_request("/applications/#{arguments.client_id}/tokens/#{arguments.access_token}", params)
-        rescue Github::Error::NotFound => e
+        rescue Github::Error::NotFound
           nil
         end
       else
diff --git a/lib/github_api/client/markdown.rb b/lib/github_api/client/markdown.rb
@@ -49,7 +49,7 @@ def render(*args)
     #
     def render_raw(*args)
       params = arguments(args).params
-      mime_type, params['data'] = params['mime'], args.shift
+      params['data'] = args.shift
       params['raw'] = true
       params['accept'] = params.fetch('accept') { 'text/plain' }
 
diff --git a/lib/github_api/client/repos.rb b/lib/github_api/client/repos.rb
@@ -282,7 +282,6 @@ def contributors(*args)
       arguments(args, required: [:user, :repo]) do
         permit %w[ anon ]
       end
-      params = arguments.params
 
       response = get_request("/repos/#{arguments.user}/#{arguments.repo}/contributors", arguments.params)
       return response unless block_given?
@@ -342,7 +341,6 @@ def edit(*args)
     # @api public
     def delete(*args)
       arguments(args, required: [:user, :repo])
-      params = arguments.params
 
       delete_request("/repos/#{arguments.user}/#{arguments.repo}", arguments.params)
     end
diff --git a/lib/github_api/client/repos/collaborators.rb b/lib/github_api/client/repos/collaborators.rb
@@ -21,7 +21,6 @@ class Client::Repos::Collaborators < API
     # @api public
     def list(*args)
       arguments(args, required: [:user, :repo])
-      params = arguments.params
 
       response = get_request("/repos/#{arguments.user}/#{arguments.repo}/collaborators", arguments.params)
       return response unless block_given?
diff --git a/lib/github_api/client/repos/releases/assets.rb b/lib/github_api/client/repos/releases/assets.rb
@@ -35,7 +35,7 @@ def list(*args)
     #
     # @api public
     def get(*args)
-      params = arguments(args, required: [:owner, :repo, :id]).params
+      arguments(args, required: [:owner, :repo, :id]).params
 
       get_request("/repos/#{arguments.owner}/#{arguments.repo}/releases/assets/#{arguments.id}" , arguments.params)
     end
diff --git a/lib/github_api/error.rb b/lib/github_api/error.rb
@@ -21,7 +21,7 @@ def initialize(message = $!)
       end
 
       def backtrace
-        if @response_message && @response_message.respond_to?(:backtrace)
+        if @response_message.respond_to?(:backtrace)
           @response_message.backtrace
         else
           super
diff --git a/lib/github_api/ext/faraday.rb b/lib/github_api/ext/faraday.rb
@@ -7,7 +7,7 @@ class ParamsHash
       def params_encoder(encoder = nil)
         if encoder
           @encoder = encoder
-        else
+        elsif defined?(@encoder)
           @encoder
         end
       end
diff --git a/lib/github_api/request/jsonize.rb b/lib/github_api/request/jsonize.rb
@@ -32,7 +32,6 @@ def encode_body(value)
     end
 
     def request_with_body?(env)
-      type = request_type(env)
       has_body?(env) and safe_to_modify?(env)
     end
 
diff --git a/lib/github_api/response_wrapper.rb b/lib/github_api/response_wrapper.rb
@@ -19,6 +19,7 @@ def initialize(response, current_api)
       @response    = response
       @current_api = current_api
       @env         = response.env
+      @body        = nil
     end
 
     # Overwrite methods to hash keys
diff --git a/spec/github/paged_request_spec.rb b/spec/github/paged_request_spec.rb
@@ -6,7 +6,7 @@
   let(:current_api) { Github::Client::Repos.new }
   let(:path) { "/repositories/"}
   let(:klass) {
-    klass = Class.new do
+    Class.new do
       include Github::PagedRequest
     end
   }
diff --git a/spec/github/validations/required_spec.rb b/spec/github/validations/required_spec.rb
@@ -6,7 +6,7 @@
 describe Github::Validations::Required do
 
   let(:validator) {
-    klaz = Class.new.extend(described_class)
+    Class.new.extend(described_class)
   }
 
   context '#assert_required_keys' do

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ def render(*args)`
`49`	`49`	`#`
`50`	`50`	`def render_raw(*args)`
`51`	`51`	`params = arguments(args).params`
`52`		`- mime_type, params['data'] = params['mime'], args.shift`
	`52`	`+ params['data'] = args.shift`
`53`	`53`	`params['raw'] = true`
`54`	`54`	`params['accept'] = params.fetch('accept') { 'text/plain' }`
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def list(*args)`
`35`	`35`	`#`
`36`	`36`	`# @api public`
`37`	`37`	`def get(*args)`
`38`		`- params = arguments(args, required: [:owner, :repo, :id]).params`
	`38`	`+ arguments(args, required: [:owner, :repo, :id]).params`
`39`	`39`
`40`	`40`	`get_request("/repos/#{arguments.owner}/#{arguments.repo}/releases/assets/#{arguments.id}" , arguments.params)`
`41`	`41`	`end`