Adds support to specify upload endpoint

shadabahmed · shadabahmed · commit f5520f86970e · 2015-12-18T13:25:08.000-08:00
Fixes piotrmurach#259
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -118,3 +118,6 @@ DEPENDENCIES
   webmock (~> 1.17.3)
   yard (~> 0.8.7)
   yardstick (~> 0.9.9)
+
+BUNDLED WITH
+   1.10.3
diff --git a/README.md b/README.md
@@ -293,6 +293,7 @@ Alternatively, you can configure the settings by passing a block to an instance
 Github.new do |c|
   c.endpoint    = 'https://github.company.com/api/v3'
   c.site        = 'https://github.company.com'
+  c.upload_endpoint = 'https://github.company.com'
 end
 ```
 
@@ -609,9 +610,9 @@ class GithubController < ApplicationController
     access_token = github.get_token authorization_code
     access_token.token   # => returns token value
   end
-  
+
   private
-  
+
    def github
     @github ||= Github.new client_id: '...', client_secret: '...'
    end
diff --git a/lib/github_api/client/repos/releases/assets.rb b/lib/github_api/client/repos/releases/assets.rb
@@ -70,7 +70,7 @@ def upload(*args)
       file = Faraday::UploadIO.new(arguments.filepath, type)
       options = {
         headers: { content_type: type },
-        endpoint: 'https://uploads.github.com',
+        endpoint: upload_endpoint,
         query: {'name' => params['name']}
       }
       params['data']    = file.read
diff --git a/lib/github_api/configuration.rb b/lib/github_api/configuration.rb
@@ -30,6 +30,9 @@ class Configuration < API::Config
     # The web endpoint used to connect to GitHub if none is set
     property  :site, default: 'https://github.com'.freeze
 
+    # The web endpoint used to upload release assets to GitHub if none is set
+    property  :upload_endpoint, default: 'https://uploads.github.com'.freeze
+
     # The default SSL configuration
     property  :ssl, default: {
       :ca_file => File.expand_path('../ssl_certs/cacerts.pem', __FILE__)
diff --git a/spec/github/client/repos/assets/upload_spec.rb b/spec/github/client/repos/assets/upload_spec.rb
@@ -8,7 +8,7 @@
   let(:id)       { 1 }
   let(:filepath) { 'batman.js' }
   let(:file)     { double(:file, read: nil, close: nil) }
-  let(:endpoint) { 'https://uploads.github.com' }
+  let(:endpoint) { Github.upload_endpoint }
   let(:inputs)   { {name: 'batman.jpg', content_type: 'application/javascript'} }
   let(:path)     { "/repos/#{owner}/#{repo}/releases/#{id}/assets" }
 
diff --git a/spec/github/configuration_spec.rb b/spec/github/configuration_spec.rb
@@ -14,6 +14,8 @@
 
   its(:site) { should == 'https://github.com' }
 
+  its(:upload_endpoint) { should == 'https://uploads.github.com' }
+
   its(:user_agent) { should =~ /Github API Ruby Gem/ }
 
   its(:oauth_token) { should be_nil }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ def upload(*args)`
`70`	`70`	`file = Faraday::UploadIO.new(arguments.filepath, type)`
`71`	`71`	`options = {`
`72`	`72`	`headers: { content_type: type },`
`73`		`- endpoint: 'https://uploads.github.com',`
	`73`	`+ endpoint: upload_endpoint,`
`74`	`74`	`query: {'name' => params['name']}`
`75`	`75`	`}`
`76`	`76`	`params['data'] = file.read`