Skip to content

Commit 6ac2db5

Browse files
committed
AdbClient: Added more verbose message for version check
- Version 4.2.2 - Corrected usage in example script
1 parent d1e50d4 commit 6ac2db5

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

AndroidViewClient/examples/screenshot-monkeyrunner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from com.android.monkeyrunner import MonkeyRunner, MonkeyDevice
1414

1515
if len(sys.argv) < 2:
16-
print >> sys.stderr, "usage: %s filename.png [serialno]" % sys.argv[0]
16+
print >> sys.stderr, "usage: %s filename.png" % sys.argv[0]
1717
sys.exit(1)
1818

1919
filename = sys.argv.pop(1)

AndroidViewClient/src/com/dtmilano/android/adb/adbclient.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
@author: Diego Torres Milano
1818
'''
1919

20-
__version__ = '4.2.0'
20+
__version__ = '4.2.2'
2121

2222
import sys
2323
import socket
@@ -177,8 +177,9 @@ def checkVersion(self, reconnect=True):
177177
print >> sys.stderr, "checkVersion(reconnect=%s)" % reconnect
178178
self.__send('host:version', reconnect=False)
179179
version = self.socket.recv(8)
180-
if version != '0004001f':
181-
raise RuntimeError("ERROR: Incorrect version %s" % (version))
180+
VERSION='0004001f'
181+
if version != VERSION:
182+
raise RuntimeError("ERROR: Incorrect ADB server version %s (expecting %s)" % (version, VERSION))
182183
if reconnect:
183184
self.__connect()
184185

@@ -368,4 +369,4 @@ def wake(self):
368369

369370
print "\nBye"
370371
else:
371-
print 'date:', adbClient.shell('date')
372+
print 'date:', adbClient.shell('date')

0 commit comments

Comments
 (0)