Skip to content

Commit 5979482

Browse files
sgiehlsgiehl
authored
[Coding Style] Enable rule PSR12.Classes.AnonClassDeclaration.SpaceAfterKeyword (matomo-org#21680)
* Enable rule PSR12.Classes.AnonClassDeclaration.SpaceAfterKeyword * auto apply coding style
1 parent 993c5d8 commit 5979482

7 files changed

Lines changed: 29 additions & 30 deletions

File tree

‎phpcs.xml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
<exclude name="Generic.Functions.FunctionCallArgumentSpacing.TooMuchSpaceAfterComma" />
3636
<exclude name="Generic.PHP.LowerCaseConstant.Found" />
3737
<exclude name="Generic.PHP.LowerCaseKeyword.Found" />
38-
<exclude name="PSR12.Classes.AnonClassDeclaration.SpaceAfterKeyword" />
3938
<exclude name="PSR12.Classes.ClassInstantiation.MissingParentheses" />
4039
<exclude name="PSR12.Classes.OpeningBraceSpace.Found" />
4140
<exclude name="PSR12.ControlStructures.BooleanOperatorPlacement.FoundMixed" />

‎plugins/ScheduledReports/tests/Integration/ApiTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function test_sendReport_overridesParametersCorrectly()
8383

8484
Piwik::addAction(APIScheduledReports::GET_RENDERER_INSTANCE_EVENT, function (&$reportRenderer, $reportType, $outputType, $report) {
8585
if ($reportType == 'dummyrepor') { // apparently this gets cut off
86-
$reportRenderer = new class() extends ReportRenderer {
86+
$reportRenderer = new class () extends ReportRenderer {
8787
public function setLocale($locale) {}
8888
public function sendToDisk($filename) {
8989
$path = PIWIK_INCLUDE_PATH . '/tmp/' . $filename;

‎tests/PHPUnit/Integration/ArchiveProcessingTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ private function _createArchiveProcessorInst($periodLabel, $dateLabel, $idSite,
102102
}
103103
$archiveWriter = new ArchiveWriter($params);
104104
$logAggregator = new LogAggregator($params);
105-
$archiveProcessor = new class($params, $archiveWriter, $logAggregator) extends ArchiveProcessor {
105+
$archiveProcessor = new class ($params, $archiveWriter, $logAggregator) extends ArchiveProcessor {
106106
private $captureInserts = false;
107107
private $capturedInserts = [];
108108

‎tests/PHPUnit/Integration/MailTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function test_abortSendingMail()
6767

6868
protected function provideContainerConfig()
6969
{
70-
$mockTransport = new class($this) extends Mail\Transport {
70+
$mockTransport = new class ($this) extends Mail\Transport {
7171
private $testCase;
7272

7373
public function __construct(MailTest $mailTest)

‎tests/PHPUnit/Integration/SegmentTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2696,7 +2696,7 @@ private function defineEntitiesNotDirectlyJoinableToVisit()
26962696
');
26972697

26982698
// add logtable classes
2699-
$logThings = new class() extends LogTable {
2699+
$logThings = new class () extends LogTable {
27002700
public function getName()
27012701
{
27022702
return 'log_thing';
@@ -2718,7 +2718,7 @@ public function getWaysToJoinToOtherLogTables()
27182718
}
27192719
};
27202720

2721-
$logThingEvents = new class() extends LogTable {
2721+
$logThingEvents = new class () extends LogTable {
27222722
public function getname()
27232723
{
27242724
return 'log_thing_event';
@@ -2751,7 +2751,7 @@ public function getDateTimeColumn()
27512751
});
27522752

27532753
// add Dimension classes
2754-
$thingEventIdDimension = new class() extends Dimension {
2754+
$thingEventIdDimension = new class () extends Dimension {
27552755
protected $nameSingular = 'CustomReports_ThingEvent';
27562756
protected $namePlural = 'CustomReports_ThingEvents';
27572757
protected $segmentName = 'thingEventId';
@@ -2772,7 +2772,7 @@ public function configureMetrics(MetricsList $metricsList, DimensionMetricFactor
27722772
}
27732773
};
27742774

2775-
$thingValueDimension = new class() extends Dimension {
2775+
$thingValueDimension = new class () extends Dimension {
27762776
protected $nameSingular = 'CustomReports_ThingValue';
27772777
protected $namePlural = 'CustomReports_ThingValues';
27782778
protected $segmentName = 'thingValue';
@@ -2801,7 +2801,7 @@ public function configureMetrics(MetricsList $metricsList, DimensionMetricFactor
28012801
}
28022802
};
28032803

2804-
$thingNameDimension = new class() extends Dimension {
2804+
$thingNameDimension = new class () extends Dimension {
28052805
protected $nameSingular = 'CustomReports_ThingName';
28062806
protected $namePlural = 'CustomReports_ThingNames';
28072807
protected $segmentName = 'thingName';
@@ -2816,7 +2816,7 @@ public function getId()
28162816
}
28172817
};
28182818

2819-
$thingCategoryDimension = new class() extends Dimension {
2819+
$thingCategoryDimension = new class () extends Dimension {
28202820
protected $nameSingular = 'CustomReports_ThingCategory';
28212821
protected $namePlural = 'CustomReports_ThingCategories';
28222822
protected $segmentName = 'thingCategory';

‎tests/PHPUnit/Unit/ArchiveProcessor/RecordBuilderTest.php‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected function tearDown(): void
5252

5353
public function test_buildFromLogs_doesNothingIfRecordBuilderNotEnabled()
5454
{
55-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
55+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
5656
public function isEnabled(ArchiveProcessor $archiveProcessor): bool
5757
{
5858
return false;
@@ -84,7 +84,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
8484

8585
public function test_buildFromLogs_insertsDataReturnedByAggregate()
8686
{
87-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
87+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
8888
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
8989
{
9090
return [
@@ -122,7 +122,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
122122

123123
public function test_buildFromLogs_ignoresData_ifAssociatedRecordMetadataDoesNotExist()
124124
{
125-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
125+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
126126
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
127127
{
128128
return [];
@@ -146,7 +146,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
146146

147147
public function test_buildFromLogs_ignoresData_ifRecordMetadataValueExistsButIsInvalid()
148148
{
149-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
149+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
150150
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
151151
{
152152
return [
@@ -173,7 +173,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
173173

174174
public function test_buildFromLogs_usesRecordSpecificLimitAndSort_whenSpecifiedInRecordMetadata()
175175
{
176-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
176+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
177177
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
178178
{
179179
return [
@@ -212,7 +212,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
212212

213213
public function test_buildForNonDayPeriod_doesNothingIfRecordBuilderNotEnabled()
214214
{
215-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
215+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
216216
public function isEnabled(ArchiveProcessor $archiveProcessor): bool
217217
{
218218
return false;
@@ -248,7 +248,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
248248

249249
public function test_buildForNonDayPeriod_aggregatesAllChildReports_ifNoRequestedReportsAreSpecified()
250250
{
251-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
251+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
252252
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
253253
{
254254
return [
@@ -300,7 +300,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
300300

301301
public function test_buildForNonDayPeriod_aggregatesOnlyRequestedReports_ifRequestedReportsSpecified_andNoneAlreadyExist()
302302
{
303-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
303+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
304304
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
305305
{
306306
return [
@@ -342,7 +342,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
342342

343343
public function test_buildForNonDayPeriod_aggregatesOnlyRequestedReportsThatDoNotExist_ifSomeRequestedReportsAlreadyExist()
344344
{
345-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
345+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
346346
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
347347
{
348348
return [
@@ -388,7 +388,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
388388

389389
public function test_buildForNonDayPeriod_usesCustomBlobSerializationProperties_ifSpecifiedInRecordMetadata()
390390
{
391-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
391+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
392392
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
393393
{
394394
return [
@@ -442,7 +442,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
442442

443443
public function test_buildForNonDayPeriod_correctlyAggregatesMetricsForMetricsThatAreRowCountsOfRecords()
444444
{
445-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
445+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
446446
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
447447
{
448448
return [
@@ -496,7 +496,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
496496

497497
public function test_buildForNonDayPeriod_correctlyAggregatesMetricsForMetricsThatAreRowCountsOfRecords_whenTheDependentRecordIsNotRequested()
498498
{
499-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
499+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
500500
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
501501
{
502502
return [
@@ -550,7 +550,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
550550

551551
public function test_buildForNonDayPeriod_correctlyAggregatesMetricsForMetricsThatAreRowCountsOfRecords_whenTheDependentRecordIsRequestedAndFound()
552552
{
553-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
553+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
554554
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
555555
{
556556
return [
@@ -608,7 +608,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
608608

609609
public function test_buildForNonDayPeriod_correctlyAggregatesMetricsForMetricsThatAreRecursiveRowCountsOfRecords()
610610
{
611-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
611+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
612612
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
613613
{
614614
return [
@@ -690,7 +690,7 @@ public function test_getQueryOriginHint_usesDerivedClassNameAsTheDefaultQueryOri
690690

691691
public function test_isBuilderForAtLeastOneOf_returnsTrue_ifTheRecordBuilderHasMetadataForAtLeastOneRequestedRecord()
692692
{
693-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
693+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
694694
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
695695
{
696696
return [
@@ -716,7 +716,7 @@ protected function aggregate(ArchiveProcessor $archiveProcessor): array
716716

717717
public function test_isBuilderForAtLeastOneOf_returnsFalse_ifTheRecordBuilderDoesNotHaveMetadataForAnyRequestedReport()
718718
{
719-
$recordBuilder = new class() extends ArchiveProcessor\RecordBuilder {
719+
$recordBuilder = new class () extends ArchiveProcessor\RecordBuilder {
720720
public function getRecordMetadata(ArchiveProcessor $archiveProcessor): array
721721
{
722722
return [
@@ -753,21 +753,21 @@ public function getMockArchiveProcessor(string $period = 'day', array $requested
753753
$params->setFoundRequestedReports($foundRequestedReports);
754754
}
755755

756-
$archiveWriter = new class() extends ArchiveWriter {
756+
$archiveWriter = new class () extends ArchiveWriter {
757757
public function __construct()
758758
{
759759
// disable original constructor
760760
}
761761
};
762762

763-
$logAggregator = new class() extends LogAggregator {
763+
$logAggregator = new class () extends LogAggregator {
764764
public function __construct()
765765
{
766766
// disable original constructor
767767
}
768768
};
769769

770-
return new class($this, $addSubtablesToAggregatedTables, $params, $archiveWriter, $logAggregator) extends ArchiveProcessor {
770+
return new class ($this, $addSubtablesToAggregatedTables, $params, $archiveWriter, $logAggregator) extends ArchiveProcessor {
771771
/**
772772
* @var RecordBuilderTest
773773
*/

‎tests/PHPUnit/Unit/CliMulti/RequestParserTest.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public function test_getInProgressArchivingCommands_returnsOnlyArchivingJobs()
141141

142142
private function getMockRequestParser($supportsAsync, $psOutput)
143143
{
144-
$mock = new class($supportsAsync, $psOutput) extends RequestParser {
144+
$mock = new class ($supportsAsync, $psOutput) extends RequestParser {
145145
public $psOutput;
146146

147147
public function __construct($supportsAsync, $psOutput)

0 commit comments

Comments
 (0)