Skip to content

Commit a833846

Browse files
authored
update szymach/c-pchart (matomo-org#19604)
* update szymach/c-pchart * fix php8.1 deprecation notice
1 parent ffb210b commit a833846

3 files changed

Lines changed: 13 additions & 14 deletions

File tree

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"symfony/monolog-bridge": "~2.6.0",
6060
"symfony/polyfill-iconv": "^1.20",
6161
"symfony/polyfill-mbstring": "^1.20",
62-
"szymach/c-pchart": "3.0.13",
62+
"szymach/c-pchart": "~3.0.13",
6363
"tecnickcom/tcpdf": "~6.0",
6464
"tedivm/jshrink": "~v1.4.0",
6565
"twig/twig": "^3.0",

composer.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/DataTable/Renderer/Csv.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,13 +239,12 @@ protected function formatValue($value)
239239

240240
$value = $this->formatFormulas($value);
241241

242-
$value = str_replace(["\t"], ' ', $value);
242+
if (is_string($value)) {
243+
$value = str_replace(["\t"], ' ', $value);
243244

244-
if (is_string($value)
245-
&& (strpos($value, '"') !== false
246-
|| strpos($value, $this->separator) !== false)
247-
) {
248-
$value = '"' . str_replace('"', '""', $value) . '"';
245+
if (strpos($value, '"') !== false || strpos($value, $this->separator) !== false) {
246+
$value = '"' . str_replace('"', '""', $value) . '"';
247+
}
249248
}
250249

251250
// in some number formats (e.g. German), the decimal separator is a comma

0 commit comments

Comments
 (0)