Fix dotenv list command

ticosax · Saurabh Kumar · commit 8e6df7b1a889 · 2016-12-20T13:49:46.000+05:30
- Compute test coverage only if tests succeeds - Add changelog Thanks @ticosax closes theskumar#41
diff --git a/.travis.yml b/.travis.yml
@@ -12,7 +12,7 @@ install:
   - pip install --editable .
 script:
   - pytest -v --tb=native --cov --flake8
-after_script:
+after_success:
   - coveralls
 deploy:
   provider: pypi
diff --git a/README.rst b/README.rst
@@ -246,6 +246,7 @@ Changelog
 
 dev
 ----------
+- Fix `dotenv list` command (@ticosax)
 - Add iPython Suport (@tillahoffmann)
 
 0.6.0
@@ -268,6 +269,7 @@ dev
 - cli: Added ``-q/--quote`` option to control the behaviour of quotes around values in ``.env``. (Thanks `@hugochinchilla`_).
 - Improved test coverage.
 
+.. _@ticosax: https://github.com/ticosax
 .. _@tillahoffmann: https://github.com/tillahoffmann
 .. _@hugochinchilla: https://github.com/hugochinchilla
 .. _@isms: https://github.com/isms
diff --git a/dotenv/cli.py b/dotenv/cli.py
@@ -26,7 +26,7 @@ def list(ctx):
     '''Display all the stored key/value.'''
     file = ctx.obj['FILE']
     dotenv_as_dict = dotenv_values(file)
-    for k, v in dotenv_as_dict:
+    for k, v in dotenv_as_dict.items():
         click.echo('%s="%s"' % (k, v))
 
 
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1 +1,10 @@
+import pytest
+
 from .fixtures import *  # noqa
+
+
+@pytest.fixture
+def dotenv_file(tmpdir):
+    file_ = tmpdir.mkdir('dotenv_file').join('.env')
+    file_.write('')
+    return str(file_)
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -1,6 +1,4 @@
 # -*- coding: utf-8 -*-
-from __future__ import unicode_literals
-
 from os import environ
 from os.path import dirname, join
 
@@ -23,6 +21,19 @@ def test_get_key():
     assert success is None
 
 
+def test_list(cli, dotenv_file):
+    success, key_to_set, value_to_set = dotenv.set_key(dotenv_file, 'HELLO', 'WORLD')
+    result = cli.invoke(dotenv.cli.cli, ['--file', dotenv_file, 'list'])
+    assert result.exit_code == 0, result.output
+    assert result.output == 'HELLO="WORLD"\n'
+
+
+def test_list_wo_file(cli):
+    result = cli.invoke(dotenv.cli.cli, ['--file', 'doesnotexists', 'list'])
+    assert result.exit_code == 2, result.output
+    assert 'Invalid value for "-f"' in result.output
+
+
 def test_key_value_without_quotes():
     with open(dotenv_path, 'w') as f:
         f.write("TEST = value \n")
