Merge pull request #1874 from thetic/new-clang-warnings

basvodde · web-flow · commit 4700e91d5145 · 2025-11-29T14:08:32.000+01:00
Fix new clang warnings
diff --git a/tests/CppUTestExt/MockActualCallTest.cpp b/tests/CppUTestExt/MockActualCallTest.cpp
@@ -85,7 +85,7 @@ TEST(MockCheckedActualCall, unExpectedCallWithAnOutputParameter)
 
 TEST(MockCheckedActualCall, unExpectedCallOnObject)
 {
-    int object;
+    int object = 0;
 
     MockCheckedActualCall actualCall(1, reporter, *emptyList);
     actualCall.withName("unexpected").onObject(&object);
@@ -186,7 +186,7 @@ TEST(MockCheckedActualCall, MockIgnoredActualCallWorksAsItShould)
 
 TEST(MockCheckedActualCall, remainderOfMockActualCallTraceWorksAsItShould)
 {
-    int value;
+    int value = 0;
     const int const_value = 1;
     const unsigned char mem_buffer[] = { 0xFE, 0x15 };
     void (*function_value)() = (void (*)())0xDEAD;
diff --git a/tests/CppUTestExt/MockFailureTest.cpp b/tests/CppUTestExt/MockFailureTest.cpp
@@ -177,8 +177,8 @@ TEST(MockFailureTest, MockUnexpectedInputParameterFailure)
 
 TEST(MockFailureTest, MockUnexpectedOutputParameterFailure)
 {
-    int out1;
-    int out2;
+    int out1 = 0;
+    int out2 = 0;
     call1->withName("foo").withOutputParameterReturning("boo", &out1, sizeof(out1));
     call2->withName("foo").withOutputParameterReturning("boo", &out2, sizeof(out2));
     call3->withName("unrelated");
@@ -200,7 +200,7 @@ TEST(MockFailureTest, MockUnexpectedOutputParameterFailure)
 
 TEST(MockFailureTest, MockUnexpectedUnmodifiedOutputParameterFailure)
 {
-    int out1;
+    int out1 = 0;
     call1->withName("foo").withOutputParameterReturning("boo", &out1, sizeof(out1));
     call2->withName("foo").withUnmodifiedOutputParameter("boo");
     call3->withName("unrelated");
diff --git a/tests/CppUTestExt/MockParameterTest.cpp b/tests/CppUTestExt/MockParameterTest.cpp
@@ -650,7 +650,7 @@ TEST(MockParameterTest, noActualCallForOutputParameter)
 {
     MockFailureReporterInstaller failureReporterInstaller;
 
-    int output;
+    int output = 0;
     MockExpectedCallsListForTest expectations;
     mock().expectOneCall("foo").withOutputParameterReturning("output", &output, sizeof(output));
 
@@ -697,7 +697,7 @@ TEST(MockParameterTest, outputParameterMissing)
 {
     MockFailureReporterInstaller failureReporterInstaller;
 
-    int output;
+    int output = 0;
     MockExpectedCallsListForTest expectations;
     mock().expectOneCall("foo").withOutputParameterReturning("output", &output, sizeof(output));
     mock().actualCall("foo");

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ TEST(MockCheckedActualCall, unExpectedCallWithAnOutputParameter)`
`85`	`85`
`86`	`86`	`TEST(MockCheckedActualCall, unExpectedCallOnObject)`
`87`	`87`	`{`
`88`		`- int object;`
	`88`	`+ int object = 0;`
`89`	`89`
`90`	`90`	`MockCheckedActualCall actualCall(1, reporter, *emptyList);`
`91`	`91`	`actualCall.withName("unexpected").onObject(&object);`
`@@ -186,7 +186,7 @@ TEST(MockCheckedActualCall, MockIgnoredActualCallWorksAsItShould)`
`186`	`186`
`187`	`187`	`TEST(MockCheckedActualCall, remainderOfMockActualCallTraceWorksAsItShould)`
`188`	`188`	`{`
`189`		`- int value;`
	`189`	`+ int value = 0;`
`190`	`190`	`const int const_value = 1;`
`191`	`191`	`const unsigned char mem_buffer[] = { 0xFE, 0x15 };`
`192`	`192`	`void (function_value)() = (void ()())0xDEAD;`
Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,7 @@ TEST(MockParameterTest, noActualCallForOutputParameter)`
`650`	`650`	`{`
`651`	`651`	`MockFailureReporterInstaller failureReporterInstaller;`
`652`	`652`
`653`		`- int output;`
	`653`	`+ int output = 0;`
`654`	`654`	`MockExpectedCallsListForTest expectations;`
`655`	`655`	`mock().expectOneCall("foo").withOutputParameterReturning("output", &output, sizeof(output));`
`656`	`656`
`@@ -697,7 +697,7 @@ TEST(MockParameterTest, outputParameterMissing)`
`697`	`697`	`{`
`698`	`698`	`MockFailureReporterInstaller failureReporterInstaller;`
`699`	`699`
`700`		`- int output;`
	`700`	`+ int output = 0;`
`701`	`701`	`MockExpectedCallsListForTest expectations;`
`702`	`702`	`mock().expectOneCall("foo").withOutputParameterReturning("output", &output, sizeof(output));`
`703`	`703`	`mock().actualCall("foo");`