Fix CreateMeetingParameters and use PHP unit 6 to support PHP 7.0, 7.1 and 7.2

GhaziTriki · GhaziTriki · commit 64483959e579 · 2018-06-13T21:10:34.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -7,6 +7,7 @@ php:
   - '7.0'
   - '7.1'
   - '7.2'
+  - '7.3'
   - hhvm
   - nightly
 
@@ -15,6 +16,7 @@ matrix:
   allow_failures:
     - php: 5.4
     - php: 5.5
+    - php: 5.6
 
 env:
   global:
diff --git a/README.md b/README.md
@@ -10,6 +10,7 @@
 [![PHP 7](https://img.shields.io/badge/php-7-8892BF.svg?style=flat-square)](https://php.net/)
 [![PHP 7.1](https://img.shields.io/badge/php-7.1-8892BF.svg?style=flat-square)](https://php.net/)
 [![PHP 7.2](https://img.shields.io/badge/php-7.2-8892BF.svg?style=flat-square)](https://php.net/)
+[![PHP 7.3](https://img.shields.io/badge/php-7.3-8892BF.svg?style=flat-square)](https://php.net/)
 
 # BigBlueButton API for PHP
 
diff --git a/composer.json b/composer.json
@@ -30,11 +30,11 @@
     "php": ">=7.0",
     "ext-mbstring": "*",
     "composer/composer": "1.7.*@dev",
-    "phpunit/phpunit": "7.1.*",
+    "phpunit/phpunit": "6.*",
     "fzaninotto/faker": "~1.7.1",
     "friendsofphp/php-cs-fixer": "~2.11",
     "squizlabs/php_codesniffer": "3.*",
-    "satooshi/php-coveralls": "2.*"
+    "php-coveralls/php-coveralls": "2.1.*"
   },
   "autoload": {
     "psr-4": {
diff --git a/src/Parameters/CreateMeetingParameters.php b/src/Parameters/CreateMeetingParameters.php
@@ -16,7 +16,6 @@
  * You should have received a copy of the GNU Lesser General Public License along
  * with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.
  */
-
 namespace BigBlueButton\Parameters;
 
 /**
@@ -445,12 +444,13 @@ public function isWebcamsOnlyForModerator()
     }
 
     /**
-     * @param bool $webcamsOnlyForModerator
+     * @param  bool                    $webcamsOnlyForModerator
      * @return CreateMeetingParameters
      */
     public function setWebcamsOnlyForModerator($webcamsOnlyForModerator)
     {
         $this->webcamsOnlyForModerator = $webcamsOnlyForModerator;
+
         return $this;
     }
 
@@ -463,12 +463,13 @@ public function getLogo()
     }
 
     /**
-     * @param string $logo
+     * @param  string                  $logo
      * @return CreateMeetingParameters
      */
     public function setLogo($logo)
     {
         $this->logo = $logo;
+
         return $this;
     }
 
@@ -481,12 +482,13 @@ public function getCopyright()
     }
 
     /**
-     * @param string $copyright
+     * @param  string                  $copyright
      * @return CreateMeetingParameters
      */
     public function setCopyright($copyright)
     {
         $this->copyright = $copyright;
+
         return $this;
     }
 
@@ -499,12 +501,13 @@ public function isMuteOnStart()
     }
 
     /**
-     * @param bool $muteOnStart
+     * @param  bool                    $muteOnStart
      * @return CreateMeetingParameters
      */
     public function setMuteOnStart($muteOnStart)
     {
         $this->muteOnStart = $muteOnStart;
+
         return $this;
     }
 
@@ -574,7 +577,7 @@ public function getHTTPQuery()
             'allowStartStopRecording' => $this->allowStartStopRecording ? 'true' : 'false',
             'welcome'                 => trim($this->welcomeMessage),
             'moderatorOnlyMessage'    => trim($this->moderatorOnlyMessage),
-            'webcamsOnlyForModerator' => $this->webcamsOnlyForModerator ?  ? 'true' : 'false',
+            'webcamsOnlyForModerator' => $this->webcamsOnlyForModerator ? 'true' : 'false',
             'logo'                    => $this->logo,
             'copyright'               => $this->copyright,
             'muteOnStart'             => $this->muteOnStart,

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@`
`16`	`16`	`* You should have received a copy of the GNU Lesser General Public License along`
`17`	`17`	`* with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.`
`18`	`18`	`*/`
`19`		`-`
`20`	`19`	`namespace BigBlueButton\Parameters;`
`21`	`20`
`22`	`21`	`/**`
`@@ -445,12 +444,13 @@ public function isWebcamsOnlyForModerator()`
`445`	`444`	`}`
`446`	`445`
`447`	`446`	`/**`
`448`		`- * @param bool $webcamsOnlyForModerator`
	`447`	`+ * @param bool $webcamsOnlyForModerator`
`449`	`448`	`* @return CreateMeetingParameters`
`450`	`449`	`*/`
`451`	`450`	`public function setWebcamsOnlyForModerator($webcamsOnlyForModerator)`
`452`	`451`	`{`
`453`	`452`	`$this->webcamsOnlyForModerator = $webcamsOnlyForModerator;`
	`453`	`+`
`454`	`454`	`return $this;`
`455`	`455`	`}`
`456`	`456`
`@@ -463,12 +463,13 @@ public function getLogo()`
`463`	`463`	`}`
`464`	`464`
`465`	`465`	`/**`
`466`		`- * @param string $logo`
	`466`	`+ * @param string $logo`
`467`	`467`	`* @return CreateMeetingParameters`
`468`	`468`	`*/`
`469`	`469`	`public function setLogo($logo)`
`470`	`470`	`{`
`471`	`471`	`$this->logo = $logo;`
	`472`	`+`
`472`	`473`	`return $this;`
`473`	`474`	`}`
`474`	`475`
`@@ -481,12 +482,13 @@ public function getCopyright()`
`481`	`482`	`}`
`482`	`483`
`483`	`484`	`/**`
`484`		`- * @param string $copyright`
	`485`	`+ * @param string $copyright`
`485`	`486`	`* @return CreateMeetingParameters`
`486`	`487`	`*/`
`487`	`488`	`public function setCopyright($copyright)`
`488`	`489`	`{`
`489`	`490`	`$this->copyright = $copyright;`
	`491`	`+`
`490`	`492`	`return $this;`
`491`	`493`	`}`
`492`	`494`
`@@ -499,12 +501,13 @@ public function isMuteOnStart()`
`499`	`501`	`}`
`500`	`502`
`501`	`503`	`/**`
`502`		`- * @param bool $muteOnStart`
	`504`	`+ * @param bool $muteOnStart`
`503`	`505`	`* @return CreateMeetingParameters`
`504`	`506`	`*/`
`505`	`507`	`public function setMuteOnStart($muteOnStart)`
`506`	`508`	`{`
`507`	`509`	`$this->muteOnStart = $muteOnStart;`
	`510`	`+`
`508`	`511`	`return $this;`
`509`	`512`	`}`
`510`	`513`
`@@ -574,7 +577,7 @@ public function getHTTPQuery()`
`574`	`577`	`'allowStartStopRecording' => $this->allowStartStopRecording ? 'true' : 'false',`
`575`	`578`	`'welcome' => trim($this->welcomeMessage),`
`576`	`579`	`'moderatorOnlyMessage' => trim($this->moderatorOnlyMessage),`
`577`		`- 'webcamsOnlyForModerator' => $this->webcamsOnlyForModerator ? ? 'true' : 'false',`
	`580`	`+ 'webcamsOnlyForModerator' => $this->webcamsOnlyForModerator ? 'true' : 'false',`
`578`	`581`	`'logo' => $this->logo,`
`579`	`582`	`'copyright' => $this->copyright,`
`580`	`583`	`'muteOnStart' => $this->muteOnStart,`