Improve processXmlResponse in BigBlueButton main class.

GhaziTriki · GhaziTriki · commit b1b084284731 · 2018-08-12T19:42:48.000+01:00
diff --git a/.travis.yml b/.travis.yml
@@ -22,7 +22,7 @@ matrix:
 env:
   global:
     - BBB_SECRET=8cd8ef52e8e101574e400365b55e11a6
-    - BBB_SERVER_BASE_URL=http://test-install.blindsidenetworks.com/bigbluebutton/
+    - BBB_SERVER_BASE_URL=https://test-install.blindsidenetworks.com/bigbluebutton/
 
 before_script:
   - wget http://getcomposer.org/composer.phar
diff --git a/composer.json b/composer.json
@@ -24,7 +24,9 @@
   },
   "require": {
     "php": ">=5.4",
-    "ext-curl": "*"
+    "ext-curl": "*",
+    "ext-simplexml": "*",
+    "ext-mbstring": "*"
   },
   "require-dev": {
     "php": ">=7.0",
diff --git a/src/BigBlueButton.php b/src/BigBlueButton.php
@@ -368,19 +368,19 @@ private function processXmlResponse($url, $payload = '', $contentType = 'applica
                 throw new \RuntimeException('Unhandled curl error: ' . curl_error($ch));
             }
             $timeout = 10;
-            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
+            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 1);
             curl_setopt($ch, CURLOPT_ENCODING, 'UTF-8');
             curl_setopt($ch, CURLOPT_URL, $url);
             curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
             curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $timeout);
-            if ($payload != '') {
+            if (!empty($payload)) {
                 curl_setopt($ch, CURLOPT_HEADER, 0);
                 curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
                 curl_setopt($ch, CURLOPT_POST, 1);
                 curl_setopt($ch, CURLOPT_POSTFIELDS, $payload);
                 curl_setopt($ch, CURLOPT_HTTPHEADER, [
                     'Content-type: ' . $contentType,
-                    'Content-length: ' . strlen($payload),
+                    'Content-length: ' . mb_strlen($payload),
                 ]);
             }
             $data = curl_exec($ch);
@@ -390,18 +390,8 @@ private function processXmlResponse($url, $payload = '', $contentType = 'applica
             curl_close($ch);
 
             return new SimpleXMLElement($data);
-        }
-
-        if ($payload != '') {
+        } else {
             throw new \RuntimeException('Post XML data set but curl PHP module is not installed or not enabled.');
         }
-
-        try {
-            $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS);
-
-            return new SimpleXMLElement($response);
-        } catch (\RuntimeException $e) {
-            throw new \RuntimeException('Failover curl error: ' . $e->getMessage());
-        }
     }
 }
diff --git a/src/Exceptions/ChecksumException.php b/src/Exceptions/ChecksumException.php
