refs pmengal#10 - vCalendar Date parse bug

reinaldocoelho · reinaldocoelho · commit c4937f18d42e · 2016-11-21T18:36:33.000-02:00
diff --git a/Class Library/ActiveUp.Net.Groupware/vCalendar/Parser.cs b/Class Library/ActiveUp.Net.Groupware/vCalendar/Parser.cs
@@ -150,7 +150,7 @@ public static DateTime ParseDate(string input)
                     input = input.Insert(4, "-");
                     input = input.Insert(7, "-");
                 }
-                else if (input.Length == 16)
+                else if (input.Length >= 15)
                 {
                     input = input.Insert(4, "-");
                     input = input.Insert(7, "-");
diff --git a/Class Library/ActiveUp.Net.Tests/ActiveUp.Net.Tests.csproj b/Class Library/ActiveUp.Net.Tests/ActiveUp.Net.Tests.csproj
@@ -59,9 +59,9 @@
     <AssemblyOriginatorKeyFile>ActiveUp.Net.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="nunit.framework, Version=2.4.1.0, Culture=neutral, PublicKeyToken=96d09a1eb7f44a77">
-      <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\..\Libs\nunit.framework.dll</HintPath>
+    <Reference Include="nunit.framework, Version=3.5.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb, processorArchitecture=MSIL">
+      <HintPath>..\..\packages\NUnit.3.5.0\lib\net40\nunit.framework.dll</HintPath>
+      <Private>True</Private>
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core">
diff --git a/Class Library/ActiveUp.Net.Tests/Common/MimePartTests.cs b/Class Library/ActiveUp.Net.Tests/Common/MimePartTests.cs
diff --git a/Class Library/ActiveUp.Net.Tests/Common/RFC2047/Rfc2047DecoderTests.cs b/Class Library/ActiveUp.Net.Tests/Common/RFC2047/Rfc2047DecoderTests.cs
@@ -143,7 +143,7 @@ public void should_handle_sample_headers()
         }
 
         // This test is an example of how to do A/B testing for a header parser modification
-        [Test, Ignore]
+        [Test, Ignore("Manual test")]
         public void parser_evolution_example()
         {
             var allHeaders = File.ReadAllText("resource\\sample_headers.txt").Split(new[] { "\r\n\r\n\r\n" }, StringSplitOptions.RemoveEmptyEntries);
diff --git a/Class Library/ActiveUp.Net.Tests/Groupware/ParserTests.cs b/Class Library/ActiveUp.Net.Tests/Groupware/ParserTests.cs
@@ -1,19 +1,29 @@
 ﻿using ActiveUp.Net.Groupware.vCalendar;
 using NUnit.Framework;
+using System;
 
 namespace ActiveUp.Net.Tests.Groupware
 {
     [TestFixture]
     public class ParserTests
     {
         [Test]
-        public void should_parse_simple_date()
+        public void should_parse_simple_file()
         {
             var vcal = Parser.Parse("TODO:");
 
             Assert.AreEqual(0, vcal.Todos.Count);
             Assert.AreEqual(0, vcal.Events.Count);
         }
 
+        [Test]
+        public void should_parse_simple_date()
+        {
+            var date = Parser.ParseDate("2016-11-21");
+            Assert.AreEqual(new DateTime(2016, 11, 21, 00, 00, 00), date);
+            var date2 = Parser.ParseDate("2016-11-21 15:30:25");
+            Assert.AreEqual(new DateTime(2016,11,21,15,30,25), date2);
+        }
+
     }
 }
diff --git a/Class Library/ActiveUp.Net.Tests/packages.config b/Class Library/ActiveUp.Net.Tests/packages.config
@@ -1,4 +1,4 @@
 ﻿<?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="NUnit" version="3.2.0" targetFramework="net40" />
+  <package id="NUnit" version="3.5.0" targetFramework="net40" />
 </packages>

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ public static DateTime ParseDate(string input)`
`150`	`150`	`input = input.Insert(4, "-");`
`151`	`151`	`input = input.Insert(7, "-");`
`152`	`152`	`}`
`153`		`- else if (input.Length == 16)`
	`153`	`+ else if (input.Length >= 15)`
`154`	`154`	`{`
`155`	`155`	`input = input.Insert(4, "-");`
`156`	`156`	`input = input.Insert(7, "-");`
Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ public void should_handle_sample_headers()`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`// This test is an example of how to do A/B testing for a header parser modification`
`146`		`- [Test, Ignore]`
	`146`	`+ [Test, Ignore("Manual test")]`
`147`	`147`	`public void parser_evolution_example()`
`148`	`148`	`{`
`149`	`149`	`var allHeaders = File.ReadAllText("resource\\sample_headers.txt").Split(new[] { "\r\n\r\n\r\n" }, StringSplitOptions.RemoveEmptyEntries);`
Original file line number	Diff line number	Diff line change
`@@ -1,19 +1,29 @@`
`1`	`1`	`using ActiveUp.Net.Groupware.vCalendar;`
`2`	`2`	`using NUnit.Framework;`
	`3`	`+using System;`
`3`	`4`
`4`	`5`	`namespace ActiveUp.Net.Tests.Groupware`
`5`	`6`	`{`
`6`	`7`	`[TestFixture]`
`7`	`8`	`public class ParserTests`
`8`	`9`	`{`
`9`	`10`	`[Test]`
`10`		`- public void should_parse_simple_date()`
	`11`	`+ public void should_parse_simple_file()`
`11`	`12`	`{`
`12`	`13`	`var vcal = Parser.Parse("TODO:");`
`13`	`14`
`14`	`15`	`Assert.AreEqual(0, vcal.Todos.Count);`
`15`	`16`	`Assert.AreEqual(0, vcal.Events.Count);`
`16`	`17`	`}`
`17`	`18`
	`19`	`+ [Test]`
	`20`	`+ public void should_parse_simple_date()`
	`21`	`+ {`
	`22`	`+ var date = Parser.ParseDate("2016-11-21");`
	`23`	`+ Assert.AreEqual(new DateTime(2016, 11, 21, 00, 00, 00), date);`
	`24`	`+ var date2 = Parser.ParseDate("2016-11-21 15:30:25");`
	`25`	`+ Assert.AreEqual(new DateTime(2016,11,21,15,30,25), date2);`
	`26`	`+ }`
	`27`	`+`
`18`	`28`	`}`
`19`	`29`	`}`