Skip to content

Commit d3dc6a5

Browse files
authored
Merge pull request piotrmurach#337 from nicolasleger/patch-1
[CI] Test against ruby 2.5
2 parents 0890821 + 014f91b commit d3dc6a5

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.travis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
language: ruby
33
sudo: false
44
cache: bundler
5-
before_install: "gem update bundler"
65
script: "bundle exec rake ci"
76
rvm:
87
- 2.0.0
98
- 2.1.10
10-
- 2.2.8
11-
- 2.3.5
12-
- 2.4.2
9+
- 2.2.9
10+
- 2.3.6
11+
- 2.4.3
12+
- 2.5.0
1313
- ruby-head
1414
- jruby-9000
1515
- jruby-head

spec/github/client/git_data/references/get_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
let(:ref) { 'branch' }
3030

3131
it "should fail to get resource with wrong ref" do
32-
expect { subject.get user, repo, '/branch' }.not_to raise_error()
32+
expect { subject.get user, repo, ref }.not_to raise_error()
3333
end
3434
end
3535

spec/github/client/git_data/references/list_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@
4949
end
5050
end
5151

52-
context 'with valid renference and refs' do
52+
context 'with valid reference and refs' do
5353
let(:ref) { 'refs/heads/lleger-refactor' }
5454

5555
it "should pass with valid reference" do
5656
expect { subject.list(user, repo, :ref => ref) }.to_not raise_error()
5757
end
5858
end
5959

60-
context 'with valid renference and refs with leading slash' do
60+
context 'with valid reference and refs with leading slash' do
6161
let(:ref) { '/refs/heads/lleger-refactor' }
6262

6363
it "should pass with valid reference" do

0 commit comments

Comments
 (0)