Suppress warnings with key/in-built method collisions

Sam Davies · Sam Davies · commit d8b83c54806d · 2017-04-02T11:18:50.000+01:00
- Use a new subclass of Hashie::Mash called Github::Mash - Fixes piotrmurach#298
diff --git a/lib/github_api/mash.rb b/lib/github_api/mash.rb
@@ -0,0 +1,5 @@
+module Github
+  class Mash < ::Hashie::Mash
+    disable_warnings
+  end
+end
diff --git a/lib/github_api/response/mashify.rb b/lib/github_api/response/mashify.rb
@@ -2,13 +2,14 @@
 
 require 'faraday'
 require 'hashie'
+require 'github_api/mash'
 
 module Github
   class Response::Mashify < Response
     dependency 'hashie/mash'
 
     define_parser do |body|
-      ::Hashie::Mash.new body
+      ::Github::Mash.new body
     end
 
     def parse(body)
diff --git a/spec/github/client/git_data/references/create_spec.rb b/spec/github/client/git_data/references/create_spec.rb
@@ -51,7 +51,7 @@
 
     it "should return the resource" do
       reference = subject.create user, repo, inputs
-      reference.first.should be_a Hashie::Mash
+      reference.first.should be_a Github::Mash
     end
 
     it "should get the reference information" do
diff --git a/spec/github/client/git_data/references/get_spec.rb b/spec/github/client/git_data/references/get_spec.rb
@@ -45,7 +45,7 @@
 
     it "should return mash" do
       reference = subject.get user, repo, ref
-      reference.first.should be_a Hashie::Mash
+      reference.first.should be_a Github::Mash
     end
   end
 
diff --git a/spec/github/client/git_data/references/list_spec.rb b/spec/github/client/git_data/references/list_spec.rb
@@ -78,7 +78,7 @@
 
     it "should be a mash type" do
       references = subject.list user, repo, :ref => ref
-      references.first.should be_a Hashie::Mash
+      references.first.should be_a Github::Mash
     end
 
     it "should get reference information" do
diff --git a/spec/github/client/git_data/references/update_spec.rb b/spec/github/client/git_data/references/update_spec.rb
@@ -46,7 +46,7 @@
 
     it "should return the resource" do
       reference = subject.update user, repo, ref, inputs
-      reference.first.should be_a Hashie::Mash
+      reference.first.should be_a Github::Mash
     end
 
     it "should get the reference information" do
diff --git a/spec/github/client/issues/labels/add_spec.rb b/spec/github/client/issues/labels/add_spec.rb
@@ -35,7 +35,7 @@
 
     it "should return the resource" do
       labels = subject.add user, repo, issue_id, label
-      labels.first.should be_a Hashie::Mash
+      labels.first.should be_a Github::Mash
     end
 
     it "should get the label information" do
diff --git a/spec/github/client/issues/labels/remove_spec.rb b/spec/github/client/issues/labels/remove_spec.rb
@@ -31,7 +31,7 @@
 
     it "should return the resource" do
       labels = subject.remove user, repo, number, :label_name => label_name
-      labels.first.should be_a Hashie::Mash
+      labels.first.should be_a Github::Mash
     end
 
     it "should get the label information" do
diff --git a/spec/github/client/issues/labels/replace_spec.rb b/spec/github/client/issues/labels/replace_spec.rb
@@ -33,7 +33,7 @@
 
     it "should return the resource" do
       labels = subject.replace user, repo, number, label
-      labels.first.should be_a Hashie::Mash
+      labels.first.should be_a Github::Mash
     end
 
     it "should get the label information" do
diff --git a/spec/github/mash_spec.rb b/spec/github/mash_spec.rb
@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'github_api/mash'
+
+describe Github::Mash do
+  it 'suppresses warnings for key/method conflict' do
+    expect(Hashie.logger).to_not receive(:warn)
+    Github::Mash.new(size: 1)
+  end
+
+  it 'inherits from Hashie::Mash' do
+    expect(Github::Mash.new(size: 1)).to be_a(::Hashie::Mash)
+  end
+end
diff --git a/spec/shared/array_of_resources_behaviour.rb b/spec/shared/array_of_resources_behaviour.rb
@@ -10,6 +10,6 @@
 
   it "should be a mash type" do
     objects = requestable
-    objects.first.should be_a Hashie::Mash
+    objects.first.should be_a ::Github::Mash
   end
 end
