fix ~ support

daniithethomp · daniithethomp · commit 4d7f6b00f265 · 2025-05-24T00:22:08.000+01:00
diff --git a/src/cd_command.cpp b/src/cd_command.cpp
@@ -3,12 +3,14 @@
 #include <unistd.h>
 
 void CdCommand::execute(const std::string& args) {
-    int first_slash = args.find_first_of('/');
-    std::string first_dir = args.substr(0, first_slash);
-    if (first_dir == "~") {
-       chdir((getenv("HOME")+"/"+args.substr(first_slash)).c_str());
+    std::string path = args;
+    if (args[0] == '~') {
+        const char* home = getenv("HOME");
+        if(home) {
+            path = std::string(home) + args.substr(1);
+        }
     }
-    else if (chdir(args.c_str()) != 0) {
+    if (chdir(path.c_str()) != 0) {
         std::cerr << "cd: " << args << ": No such file or directory" << std::endl;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -3,12 +3,14 @@`
`3`	`3`	`#include <unistd.h>`
`4`	`4`
`5`	`5`	`void CdCommand::execute(const std::string& args) {`
`6`		`- int first_slash = args.find_first_of('/');`
`7`		`- std::string first_dir = args.substr(0, first_slash);`
`8`		`- if (first_dir == "~") {`
`9`		`- chdir((getenv("HOME")+"/"+args.substr(first_slash)).c_str());`
	`6`	`+ std::string path = args;`
	`7`	`+ if (args[0] == '~') {`
	`8`	`+ const char* home = getenv("HOME");`
	`9`	`+ if(home) {`
	`10`	`+ path = std::string(home) + args.substr(1);`
	`11`	`+ }`
`10`	`12`	`}`
`11`		`- else if (chdir(args.c_str()) != 0) {`
	`13`	`+ if (chdir(path.c_str()) != 0) {`
`12`	`14`	`std::cerr << "cd: " << args << ": No such file or directory" << std::endl;`
`13`	`15`	`}`
`14`	`16`	`}`