fix: pwd command

daniithethomp · daniithethomp · commit f230749559f4 · 2025-05-23T23:37:26.000+01:00
diff --git a/src/command_factory.cpp b/src/command_factory.cpp
@@ -4,6 +4,7 @@ CommandFactory::CommandFactory() {
         commands["exit"] = std::make_unique<ExitCommand>();
         commands["echo"] = std::make_unique<EchoCommand>();
         commands["type"] = std::make_unique<TypeCommand>();
+        commands["pwd"] = std::make_unique<PwdCommand>();
 }
 
 Command* CommandFactory::get(const std::string& name) {
diff --git a/src/command_factory.h b/src/command_factory.h
@@ -6,6 +6,7 @@
 #include "exit_command.h"
 #include "echo_command.h"
 #include "type_command.h"
+#include "pwd_command.h"
 
 class CommandFactory {
     std::map<std::string, std::unique_ptr<Command>> commands;
diff --git a/src/pwd_command.cpp b/src/pwd_command.cpp
@@ -3,9 +3,8 @@
 #include <unistd.h>
 
 void PwdCommand::execute(const std::string& args) {
-    char *cwd;
-    getcwd(cwd, sizeof(cwd));
-    if (cwd != nullptr) {
+    char cwd[1024];
+    if (getcwd(cwd, sizeof(cwd)) != nullptr) {
         std::cout << cwd << std::endl;
     } else {
         std::cerr << "Error getting current working directory" << std::endl;

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ CommandFactory::CommandFactory() {`
`4`	`4`	`commands["exit"] = std::make_unique<ExitCommand>();`
`5`	`5`	`commands["echo"] = std::make_unique<EchoCommand>();`
`6`	`6`	`commands["type"] = std::make_unique<TypeCommand>();`
	`7`	`+ commands["pwd"] = std::make_unique<PwdCommand>();`
`7`	`8`	`}`
`8`	`9`
`9`	`10`	`Command* CommandFactory::get(const std::string& name) {`