Change interface to listing unauthenticated user issues.

piotrmurach · piotrmurach · commit 305f6fea1811 · 2012-05-16T22:36:42.000+01:00
diff --git a/lib/github_api/gists.rb b/lib/github_api/gists.rb
@@ -29,8 +29,8 @@ def comments
     # List a user's gists.
     #
     # = Examples
-    #  github = Github.new :user => 'user-name'
-    #  github.gists.list
+    #  github = Github.new
+    #  github.gists.list user: 'user-name'
     #
     # List the authenticated user’s gists or if called anonymously,
     # this will returns all public gists
@@ -39,11 +39,10 @@ def comments
     #  github = Github.new :oauth_token => '...'
     #  github.gists.list
     #
-    def list(user_name=nil, params={})
-      _update_user_repo_params(user_name)
-      process_params do
-        normalize params
-      end
+    def list(params={})
+      _normalize_params_keys(params)
+
+      user = params.delete('user')
 
       response = if user
         get_request("/users/#{user}/gists", params)
diff --git a/spec/github/gists_spec.rb b/spec/github/gists_spec.rb
@@ -21,23 +21,23 @@
         end
 
         it "should get the resources" do
-          github.gists.list user
+          github.gists.list :user => user
           a_get("/users/#{user}/gists").should have_been_made
         end
 
         it "should return array of resources" do
-          gists = github.gists.list user
+          gists = github.gists.list :user => user
           gists.should be_an Array
           gists.should have(1).items
         end
 
         it "should be a mash type" do
-          gists = github.gists.list user
+          gists = github.gists.list :user => user
           gists.first.should be_a Hashie::Mash
         end
 
         it "should get gist information" do
-          gists = github.gists.list user
+          gists = github.gists.list :user => user
           gists.first.user.login.should == 'octocat'
         end
 
@@ -55,7 +55,7 @@
 
         it "should return 404 with a message 'Not Found'" do
           expect {
-            github.gists.list user
+            github.gists.list :user => user
           }.to raise_error(Github::Error::NotFound)
         end
       end
