Escape apostrophes for JS

mattpass · mattpass · commit 4c5583e191b6 · 2014-10-28T09:14:29.000Z
diff --git a/lib/plugins-display.php b/lib/plugins-display.php
@@ -15,7 +15,7 @@
 
 	// If we're updating plugins, update those shown
 	if (isset($_GET['updatedPlugins'])) {
-		echo "<script>top.document.getElementById('pluginsOptional').innerHTML = '".$pluginsDisplay."';</script>";
+		echo "<script>top.document.getElementById('pluginsOptional').innerHTML = '".str_replace("'","\\'",$pluginsDisplay)."';</script>";
 	}
 
 	// Work out what plugins we'll need to set on a setInterval

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`// If we're updating plugins, update those shown`
`17`	`17`	`if (isset($_GET['updatedPlugins'])) {`
`18`		`- echo "<script>top.document.getElementById('pluginsOptional').innerHTML = '".$pluginsDisplay."';</script>";`
	`18`	`+ echo "<script>top.document.getElementById('pluginsOptional').innerHTML = '".str_replace("'","\\'",$pluginsDisplay)."';</script>";`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`// Work out what plugins we'll need to set on a setInterval`