Merge pull request piotrmurach#336 from nicolasleger/fix/refs_passing

piotrmurach · web-flow · commit 0890821c3f8e · 2018-03-04T13:18:01.000Z
Fix/refs passing
diff --git a/lib/github_api/client/git_data/references.rb b/lib/github_api/client/git_data/references.rb
@@ -35,8 +35,8 @@ def list(*args)
       repo = arguments.repo
 
       response = if (ref = params.delete('ref'))
-        validate_reference ref
-        get_request("/repos/#{user}/#{repo}/git/refs/#{ref}", params)
+        formatted_ref = validate_reference ref
+        get_request("/repos/#{user}/#{repo}/git/#{formatted_ref}", params)
       else
         get_request("/repos/#{user}/#{repo}/git/refs", params)
       end
@@ -143,6 +143,8 @@ def validate_reference(ref)
       unless VALID_REF_PARAM_VALUES['ref'] =~ refs
         raise ArgumentError, "Provided 'reference' is invalid"
       end
+
+      refs
     end
   end # GitData::References
 end # Github
diff --git a/spec/github/client/git_data/references/list_spec.rb b/spec/github/client/git_data/references/list_spec.rb
@@ -6,7 +6,7 @@
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:ref) { "heads/master" }
-  let(:request_path) { "/repos/#{user}/#{repo}/git/refs/#{ref}".gsub(/(\/)+/, '/') }
+  let(:request_path) { "/repos/#{user}/#{repo}/git/refs/#{ref.gsub(/^\/?refs\//, '')}".gsub(/(\/)+/, '/') }
 
   before {
     stub_get(request_path).to_return(:body => body, :status => status,
