fix(run): when target is passed to cordova through spawn remove quotes

jthoms1 · jthoms1 · commit 42fda29a48c8 · 2016-12-20T14:39:24.000-06:00
diff --git a/lib/utils/cordova.js b/lib/utils/cordova.js
@@ -10,7 +10,7 @@ var Serve = IonicAppLib.serve;
 var Project = IonicAppLib.project;
 var log = IonicAppLib.logging.logger;
 var ConfigXml = IonicAppLib.configXml;
-var crossSpawn = require('cross-spawn');  
+var crossSpawn = require('cross-spawn');
 var npmScripts = require('../utils/npmScripts');
 var serveUtils = require('../utils/serve');
 
@@ -233,14 +233,6 @@ function filterArgumentsForCordova(cmdName, argv, rawCliArguments) {
 
     // Only return true if the arg is not found in the ignore Cmds list
     return ignoreCmds.indexOf(arg) === -1;
-  }).map(function(arg) {
-
-    // If the arg is the target command and it does not contain double quotes add them
-    // because process.argv removes them
-    if (arg.indexOf('--target=') === 0 && arg.indexOf('"') === -1) {
-      return arg.replace('--target=', '--target="') + '"';
-    }
-    return arg;
   });
 }
 
diff --git a/spec/utils/cordova.spec.js b/spec/utils/cordova.spec.js
@@ -8,7 +8,7 @@ var optimist = require('optimist');
 var IonicAppLib = require('ionic-app-lib');
 var Project = require('ionic-app-lib').project;
 var Serve = require('ionic-app-lib').serve;
-var crossSpawn = require('cross-spawn'); 
+var crossSpawn = require('cross-spawn');
 var ConfigXml = require('ionic-app-lib').configXml;
 var log = IonicAppLib.logging.logger;
 
@@ -409,16 +409,6 @@ describe('filterArgumentsForCordova', function() {
     var cmdName = argv._[0];
 
     var resultArgs = cordovaUtils.filterArgumentsForCordova(cmdName, argv, rawCliArguments);
-    expect(resultArgs).toEqual(['build', '--target="ios"']);
-  });
-  it('should ensure that the --target= parameter contains double quotes when quotes are not removed', function() {
-    var processArguments = ['node', 'ionic', 'build',
-      '--target="ios"'];
-    var rawCliArguments = processArguments.slice(2);
-    var argv = optimist(rawCliArguments).argv;
-    var cmdName = argv._[0];
-
-    var resultArgs = cordovaUtils.filterArgumentsForCordova(cmdName, argv, rawCliArguments);
-    expect(resultArgs).toEqual(['build', '--target="ios"']);
+    expect(resultArgs).toEqual(['build', '--target=ios']);
   });
 });
