From 69ded7f0dba402a53d907256e0177759f87369f5 Mon Sep 17 00:00:00 2001 From: Alaeddine Abdessalem Date: Fri, 2 Sep 2022 12:47:17 +0100 Subject: [PATCH 1/3] test: start da name with letter --- tests/unit/array/mixins/test_io.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/array/mixins/test_io.py b/tests/unit/array/mixins/test_io.py index 383020fb3d2..a32fdce103e 100644 --- a/tests/unit/array/mixins/test_io.py +++ b/tests/unit/array/mixins/test_io.py @@ -228,7 +228,7 @@ def test_push_pull_io(da_cls, config, show_progress, start_storage): random_texts = [str(uuid.uuid1()) for _ in da1] da1[:, 'text'] = random_texts - name = random_identity() + name = f'docarray_ci_{random_identity()}' da1.push(name, show_progress=show_progress) From bbcaa0a3aa7f2ee56ce870d273e8b15bddc7c545 Mon Sep 17 00:00:00 2001 From: Alaeddine Abdessalem Date: Fri, 2 Sep 2022 12:48:00 +0100 Subject: [PATCH 2/3] test: remove no more available remote file from test case --- tests/unit/document/test_converters.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/unit/document/test_converters.py b/tests/unit/document/test_converters.py index 0a5f9774f5e..f9361b3912c 100644 --- a/tests/unit/document/test_converters.py +++ b/tests/unit/document/test_converters.py @@ -259,10 +259,6 @@ def test_convert_uri_to_data_uri(uri, mimetype): 'uri, chunk_num', [ (os.path.join(cur_dir, 'toydata/test.glb'), 1), - ( - 'https://storage.googleapis.com/showcase-3d-models/ShapeNetV2/airplane_aeroplane_plane_0.glb', - 16, - ), ], ) def test_glb_converters(uri, chunk_num): From a24df28cc2ecf44a73cf1ab8bc240e6a826d2a44 Mon Sep 17 00:00:00 2001 From: Alaeddine Abdessalem Date: Fri, 2 Sep 2022 17:52:22 +0100 Subject: [PATCH 3/3] test: add remote glb file case --- tests/unit/document/test_converters.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/unit/document/test_converters.py b/tests/unit/document/test_converters.py index f9361b3912c..29d594e57ba 100644 --- a/tests/unit/document/test_converters.py +++ b/tests/unit/document/test_converters.py @@ -259,6 +259,10 @@ def test_convert_uri_to_data_uri(uri, mimetype): 'uri, chunk_num', [ (os.path.join(cur_dir, 'toydata/test.glb'), 1), + ( + 'https://github.com/jina-ai/docarray/raw/main/tests/unit/document/toydata/test.glb', + 1, + ), ], ) def test_glb_converters(uri, chunk_num):