From 27b5dd6f6f5b14d7a1c96ddd7b1c972b37131b7c Mon Sep 17 00:00:00 2001 From: guenthermi Date: Mon, 26 Sep 2022 13:32:21 +0200 Subject: [PATCH 1/2] refactor: remove check of default value in _non_empty_fields --- docarray/score/data.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/docarray/score/data.py b/docarray/score/data.py index 3e47ff6377b..abfdf9e239b 100644 --- a/docarray/score/data.py +++ b/docarray/score/data.py @@ -23,12 +23,7 @@ def _non_empty_fields(self) -> Tuple[str]: if not f_name.startswith('_'): v = getattr(self, f_name) if v is not None: - if f_name not in default_values: - r.append(f_name) - else: - dv = default_values[f_name] - if v != dv: - r.append(f_name) + r.append(f_name) return tuple(r) From eb3d4da32fe7a1fdaf6f97c85a01385d1d18e9ea Mon Sep 17 00:00:00 2001 From: guenthermi Date: Tue, 27 Sep 2022 09:17:23 +0200 Subject: [PATCH 2/2] test: add test for string representation of named scores --- tests/unit/test_named_score.py | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 tests/unit/test_named_score.py diff --git a/tests/unit/test_named_score.py b/tests/unit/test_named_score.py new file mode 100644 index 00000000000..b93b9e27439 --- /dev/null +++ b/tests/unit/test_named_score.py @@ -0,0 +1,7 @@ +from docarray.score import NamedScore + + +def test_str_representation(): + assert str(NamedScore(value=0.0)) == str({'value': 0.0}) + assert str(NamedScore(value=None)) == str(dict()) + assert str(NamedScore(value=0.3)) == str({'value': 0.3})