From 624e9ee0f9da13d88bf5f51aac1c9e975209f8bf Mon Sep 17 00:00:00 2001 From: Delgermurun Date: Fri, 21 Jan 2022 16:10:32 +0100 Subject: [PATCH 1/2] refactor(document): remove duplicated constructor overload removing unused imports as well --- docarray/document/__init__.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/docarray/document/__init__.py b/docarray/document/__init__.py index 00f26b2e3eb..8bcf1174ec1 100644 --- a/docarray/document/__init__.py +++ b/docarray/document/__init__.py @@ -1,6 +1,6 @@ -from typing import overload, Dict, Optional, List, TYPE_CHECKING, Union, Sequence +from typing import overload, Dict, Optional, List, TYPE_CHECKING, Sequence -from .data import DocumentData, default_values +from .data import DocumentData from .mixins import AllMixins from ..base import BaseDCType @@ -29,15 +29,6 @@ def __init__( ): ... - @overload - def __init__( - self, - _obj: Optional[Dict], - field_resolver: Optional[Dict[str, str]] = None, - unknown_fields_handler: str = 'catch', - ): - ... - @overload def __init__( self, From b5bcb9177f976a72bdade31c872c01ab6717d990 Mon Sep 17 00:00:00 2001 From: Delgermurun Date: Fri, 21 Jan 2022 16:23:39 +0100 Subject: [PATCH 2/2] fix(document): add missing "copy" parameter to overload definition --- docarray/document/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/docarray/document/__init__.py b/docarray/document/__init__.py index 8bcf1174ec1..466a79684b7 100644 --- a/docarray/document/__init__.py +++ b/docarray/document/__init__.py @@ -24,6 +24,7 @@ def __init__(self, _obj: Optional['Document'] = None, copy: bool = False): def __init__( self, _obj: Optional[Dict], + copy: bool = False, field_resolver: Optional[Dict[str, str]] = None, unknown_fields_handler: str = 'catch', ):